06:16:58 * ** patersonc has joined #cip
07:15:10 * ** rajm has joined #cip
07:36:45 * rajm runs BBB healthcheck with email to the list
08:08:02 * ** toscalix has joined #cip
08:43:12 * ** vidda_ has joined #cip
09:00:38 <szlin> time to start meeting
09:00:43 <szlin> #startmeeting
09:00:54 <szlin> #topic roll call
09:01:07 <toscalix> o/
09:01:09 <szlin> please say hi if you are here
09:01:26 <szlin> ._.
09:01:31 <szlin> ._./
09:01:36 <vidda_> hi
09:01:47 <bwh> hi
09:01:48 <rajm> hi
09:02:30 <szlin> #topic kernel review status update
09:02:58 <moxavict1r> hi
09:02:59 <szlin> Moxa team are reviewing 4.4.130
09:03:35 <patersonc> hi
09:03:50 <gavinlai> hi
09:04:04 <szlin> the review task might be done in next week.
09:04:13 <bwh> szlin: great
09:04:35 <szlin> and the result of review will be sent out to cip-dev afterwards
09:05:09 <szlin> we have some questions in reviewing task
09:05:38 <moxavict1r> bwh: if we want to know kernel software architecture, where we can get the document ?
09:06:38 <bwh> moxavict1r: I think either the document is either in Documentation or doesn't exist
09:07:01 <bwh> In many cases, unfortunately, important information is not written down
09:07:29 <moxavict1r> can you give some comment to know kernel software architecture ?
09:08:39 <patersonc> moxavict1r: Tim Bird published this the other day: https://elinux.org/Developer_Guidelines
09:08:48 <patersonc> Perhaps some useful information there
09:09:15 <moxavict1r> OK, thank your information, I will check it
09:09:42 <patersonc> o/
09:10:46 <moxavict1r> the patched code is very much and fast, how can we more fast to review it ?
09:11:22 <moxavict1r> and how can we know it is right or good ?
09:11:45 <patersonc> Experience/manpower
09:12:12 <bwh> moxavict1r: First, ignore the changes that aren't relevant (e.g. architecture or driver not used in CIP)
09:13:22 <bwh> And like patersonc says, you will get faster with experience
09:14:11 <moxavict1r> how can I get good experience ?
09:14:28 <bwh> Without test cases for everything, you're not going to know for sure if the changes are good, but you can catch more of the bad changes
09:14:58 <bwh> Keep reviewing
09:15:13 <moxavict1r> good
09:16:07 <moxavict1r> but how we know the changes are right ?
09:16:48 <moxavict1r> eg: some changes are about kernel schedule ?
09:17:51 <bwh> If they're bad, either someone will notice during review or someone will notice afterward and you'll see another fix
09:18:18 <bwh> and if that doesn't happen, you have to assume they're good
09:18:55 <moxavict1r> so we need usually to review the code ?
09:19:47 <moxavict1r> is right ?
09:20:38 <bwh> Yes I think so
09:20:49 <moxavict1r> got it, thanks
09:21:35 <moxavict1r> can we see others code reviewer comment ?
09:22:14 <bwh> They should all be on the stable@vger.kernel.org list
09:23:06 <szlin> Have you ever rejected the patches which are from stable kernel in CIP kernel reviewing?
09:23:07 <moxavict1r> OK. I will check it.
09:23:12 <bwh> and no, there aren't many review comments - they are only sent if people notice problems
09:23:45 <szlin> (and these patches are used in CIP
09:24:01 <bwh> szlin: Yes, I have reverted them after merging from stable and also told Greg they should be reverted in the stable branch
09:24:45 <szlin> bwh: is it a bug issue?
09:26:18 <bwh> yes
09:26:23 <moxavict1r> if some changes are no body to review it, we will merge it to cip kernel ?
09:27:07 <bwh> moxavict1r: I believe I have reviewed all the relevant changes in the 4.4 stable branch before merging to CIP.
09:27:39 <bwh> I think CIP should go on doing that
09:27:52 <moxavict1r> thanks your effort and help
09:28:03 <szlin> any questions with this topic?
09:28:10 <moxavict1r> no
09:28:17 <rajm> o/ more as a WIP
09:28:32 <rajm> End of last week LAVA in stretch backports moved to version 2018-4 and then was broken
09:28:40 <rajm> now repaired but to get B@D working small change needed (now in MR) and some wiki changes - in progress
09:30:03 <szlin> rajm: will we follow the version in stable-backports?
09:30:40 <rajm> we have been - not an easy was of installing named version from linaro
09:30:45 <rajm> s/was/way/
09:31:29 <szlin> got it, thanks
09:31:42 <szlin> any questions?
09:31:54 <toscalix> need to leave too. bye
09:32:00 <rajm> _o_
09:32:02 <szlin> #endmeeting