13:28:32 <devinavery> #startmeeting jquery_xpath_for_md_sal_intern
13:28:32 <odl_meetbot> Meeting started Fri Aug 22 13:28:32 2014 UTC.  The chair is devinavery. Information about MeetBot at http://ci.openstack.org/meetbot.html.
13:28:32 <odl_meetbot> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
13:28:32 <odl_meetbot> The meeting name has been set to 'jquery_xpath_for_md_sal_intern'
13:28:41 <devinavery> #chair regXboi Neel_B
13:28:41 <odl_meetbot> Current chairs: Neel_B devinavery regXboi
13:28:57 <regXboi> morning - this is the last one, so let's button this up
13:29:05 <devinavery> #info Neel_B is having a bunch of compile errors when trying to get code running in controller.
13:29:18 <regXboi> do we have a paste bin?
13:29:25 <devinavery> #info devinavery asked Neel_B to push a draft so we can pull down to help debug
13:29:37 <devinavery> http://pastebin.com/jF1LeqtA
13:29:47 <Neel_B> https://git.opendaylight.org/gerrit/10170
13:29:55 <Neel_B> it went to drafts i guess
13:30:10 <devinavery> Perfect. Neel_B can you add me and Ryan as reviewers.
13:30:30 <Neel_B> your emails right ?
13:30:30 <devinavery> You can find me under "Devin Avery" <devin.avery@brocade.com>
13:30:33 <regXboi> that will be necessary for us to see the patch
13:30:40 <devinavery> That should give us permissions to see the draft
13:31:00 <regXboi> and I'm rmoats@us.ibm.com
13:31:09 <devinavery> regXboi: my guess on the error is that there is a scope issue with the dependencies, most likely because the pom.xml was intended to be a test-it bundle only.
13:31:25 <regXboi> it sure looks like it from reading
13:31:40 <regXboi> but there are some other possibilities
13:32:06 <Neel_B> done
13:32:52 <devinavery> Ok. Pulling in
13:34:10 <regXboi> ditto and starting a build to watch it go boom
13:35:36 <regXboi> well... I think I want to change the snapshot version
13:37:03 <regXboi> ok, it looks to me like we are missing at least one dependency
13:37:07 <regXboi> and probably more
13:39:34 <regXboi> have we added the dependency on yang-data-api?
13:39:45 <devinavery> That is the one tha tis missing
13:39:46 <devinavery> <dependency>
13:39:46 <devinavery> <groupId>org.opendaylight.yangtools</groupId>
13:39:47 <devinavery> <artifactId>yang-data-api</artifactId>
13:39:49 <devinavery> </dependency>
13:40:47 <Neel_B> just added
13:41:03 <regXboi> and that will fix the compile and get us to the tests
13:41:21 <regXboi> one other things - let's add the following to the pom.xml:
13:41:41 <regXboi> after the description:
13:41:51 <regXboi> <version>0.1-SNAPSHOT</version>
13:41:55 <Neel_B> compiled and tunning tests
13:42:04 <Neel_B> willbe failing
13:42:20 <devinavery> Also - the artifactId should match the folder name. In this case we have sal-xpath so that should be the artifact id
13:42:42 <regXboi> yes
13:43:08 <regXboi> that also will help the tests
13:43:09 <regXboi> (some)
13:43:52 <regXboi> ok... now the problem with the test is that bundle we just built isn't being included
13:44:47 <Neel_B> i guess artifact id is correct ?
13:45:05 <regXboi> artifact id of the parent is sal-parent
13:45:16 <regXboi> but artifact id of the bundle should be sal-xpath, not sample-path
13:45:39 <Neel_B> changed sal-xpath
13:47:22 <Neel_B> should we change some parts of test code too ?
13:49:01 <regXboi> well... it looks like we may have to break the tests into a separate bundle
13:49:06 <regXboi> which I really don't want to do
13:49:32 <Neel_B> okay but the bundle runs like an it
13:49:37 <Neel_B> i guess
13:50:49 <regXboi> ok
13:50:56 <regXboi> yes I think we can make this work
13:51:03 <regXboi> can one of you try the following
13:51:28 <regXboi> Tin
13:51:37 <regXboi> in toastertest.java
13:51:42 <regXboi> lines 133 and 134
13:51:49 <regXboi> uncomment and replace with the following:
13:51:54 <regXboi> mavenBundle( "org.opendaylight.controller",                  "sal-xpath" ).versionAsInProject(),
13:52:08 <regXboi> that should pull in our bundle for the test and then the test should run
13:52:11 <devinavery> Was just looking to see if we included our project. :)
13:52:26 <regXboi> I'm getting a versioning error on my setup - but that was what I've been getting for a while now
13:52:44 <devinavery> I am getting a version error now
13:52:53 <devinavery> Missing a dependency for sal-xpath in your maven project
13:52:54 <devinavery> ...
13:53:23 <regXboi> did you set the version in the pom.xml directly?
13:53:24 <devinavery> 4wait.. it is sample-xpath in my environment still.. one sec
13:53:39 <regXboi> I changed it to <version>0.1-SNAPSHOT</version> in mine
13:53:48 <regXboi> and so I'm failing on
13:53:49 <regXboi> java.lang.RuntimeException: Could not resolve version. Do you have a dependency for org.opendaylight.controller.samples/sample-toaster-provider in your maven project?
13:53:52 <devinavery> The problem was that I did not change my artifact id
13:53:56 <regXboi> :)
13:54:01 <regXboi> that can be painful
13:54:07 <devinavery> When I used "sample-xpath" for the dependency it ran successfully
13:54:33 <devinavery> So Neel_B: change the artifact ID in the pom.xml, then add regXboi's line above into the ToasterTest
13:54:38 <regXboi> ok, then I think we make these changes, and we can change this from draft to visible and I am happy
13:54:52 <devinavery> that should get it so the test runs failing on a verification now instead of a compilation / runtime error
13:54:53 <Neel_B> but the tests are failing right ?
13:55:40 <devinavery> Neel_B: I would comment out the verification looking for ChildToasterList - right now the OpendayLightToaster that is in source ( that we use) doesn't publish that. So commenting out those path validations will allow the test to pass
13:55:48 <devinavery> Just put a TODO in there for anyone who comes in the future
13:57:00 <Neel_B> where to put TODO ?
13:57:38 <Neel_B> org.sonatype.aether.transfer.ArtifactNotFoundException: Could not find artifact org.opendaylight.controller:sal-xpath:jar:0.1-SNAPSHOT in central (http://repo1.maven.org/maven2/)
13:58:16 <regXboi> first, the todo goes where the verification for child toaster list is commented out
13:58:29 <devinavery> Neel_B: have you recompiled the toaster project after modifying the pom and ToasterTest? ToDo go where regXboi said
13:58:31 <regXboi> second, how are you running the code to get that error?
13:58:53 <Neel_B> cd sal-xpath
13:58:58 <Neel_B> mvn clean install
14:00:40 <regXboi> that error says you aren't looking at your local install
14:06:38 <regXboi> devinavery: unfortunately I'm blocked on this sample-toaster-provider version bug that my install seems to have
14:06:47 <regXboi> can you see if you can make the tests work?
14:07:58 <Neel_B> i am trying
14:08:25 <devinavery> regXboi: Ok I saw your change worked just fine.
14:08:54 <devinavery> Neel_B: if you are stuck, please upload your code again (push another draft) so I can pull it down again to see if the problem shows up
14:09:47 <Neel_B> just a sec i am tryin to clear out
14:09:59 <Neel_B> let me try again and will push it
14:10:14 <regXboi> devinavery: I'm at neel's point now - I expect that the options need to be looked at
14:13:30 <devinavery> strange that I am not seeing that error...
14:13:50 <devinavery> I will pull Neel's code when it is pushed and retry
14:14:50 <regXboi> I think it may have to do with aether version and or configuration
14:15:09 <Neel_B> https://git.opendaylight.org/gerrit/10172
14:16:11 <regXboi> um
14:16:18 <regXboi> you shouldn't have pushed it as a new patch
14:16:26 <regXboi> you should have pushed it as a revision of the old patch
14:17:35 <Neel_B> okay
14:17:37 <Neel_B> added
14:17:40 <Neel_B> you both
14:18:36 <regXboi> well first of all
14:18:49 <devinavery> Neel - did you follow regXboi's comment about pushing a new patch to the same draft?
14:19:28 <Neel_B> how to do that
14:20:02 <regXboi> I believe we have to comment out the child toaster tests as well as that isn't part of the standard toaster eithre
14:20:30 <regXboi> when you push the patch, you have to change the commit message to include the patch identifier of the original patch
14:20:31 <devinavery> You edit the previous commit using " commit --amend"  --- that will basically edit the previous commit you pushed
14:20:43 <regXboi> devinavery has the easy way :)
14:21:34 <Neel_B> okay i thought i pushed it so it won't work
14:21:50 <regXboi> you did
14:21:51 <Neel_B> from now i will do that
14:22:03 <regXboi> oh n/m my comment :)
14:22:06 <regXboi> wrong window
14:22:17 <devinavery> The problem Neel is that your changes are now spread out over two gerrits
14:22:51 <devinavery> So what we should do is collapse the patches back together and just push a second patch to the first git
14:23:01 <regXboi> yes
14:23:12 <regXboi> devinavery: can you walk through that?  I have to get on a phone call
14:23:27 <devinavery> regXboi... I can try. I am relatively new to git. :)
14:23:31 <regXboi> ugh
14:23:33 <devinavery> But let me see if I can remember how to do that
14:23:45 <devinavery> ( I think I can dig up my notes)
14:23:52 <regXboi> ok
14:24:00 <regXboi> I'll be back when I'm done
14:24:06 <devinavery> ok
14:24:31 <Neel_B> git rest --soft HEAD~2
14:24:36 <Neel_B> reset*
14:24:48 <Neel_B> is it that ?
14:24:59 <devinavery> Ahh... almost... try this
14:25:15 <devinavery> FIRST - copy your code to another folder outside of the control r- don't want to loose it. ;0
14:25:46 <devinavery> Next , run "git log". This should print out the history of all commits in your build. Your last two commits should be at the top - correct?
14:25:50 <Neel_B> actually did it already
14:25:55 <devinavery> Oh.. alright.
14:26:27 <Neel_B> last commits weren't mine
14:26:28 <Neel_B> now
14:26:50 <Neel_B> so what do i do
14:27:03 <Neel_B> will those gerrits be gone
14:27:03 <Neel_B> ?
14:27:05 <devinavery> Ok, so I think you went to far back
14:27:11 <devinavery> No - the gerrits are still there.
14:27:19 <devinavery> if you do a git status, what shows up?
14:30:59 <Neel_B_> devinavery: the whole sal-xpth in git status
14:31:38 <devinavery> Ok. Do another git commit.
14:31:58 <devinavery> But this time, in your commit message, make sure that you have the change ID for the first git
14:34:03 <Neel_B_> okay
14:34:05 <Neel_B_> then
14:34:21 <devinavery> Ok. SO what does your commit message look like?
14:34:29 <Neel_B_> how to remove the second gerrit ?
14:34:44 <devinavery> You can just discard it from the gerrit UI in a little bit
14:34:56 <Neel_B_> [DO NOT MERGE] Initial code prototype for XPath query capabilities on MD-SAL  Change-Id: Ica3e660c14b834e42e5cfe5cb9ca17b01e3aa8f9 Signed-off-by: Neel <neel250294@gmail.com>
14:35:01 <devinavery> For now lets just push the new patch to the exist gerrit and see if it works
14:35:03 <devinavery> Ok that looks good
14:35:17 <devinavery> go ahead and push it again. It should show up as a new patch on the existing gerrit
14:36:31 <Neel_B_> new gerrit
14:37:27 <devinavery> Can you post link?
14:37:39 <devinavery> If it has everything then we will just go with that one and discard the other two
14:38:09 <Neel_B_> https://git.opendaylight.org/gerrit/#/c/10173/
14:38:38 <devinavery> Ok. Please add me to the reviewers.
14:39:09 <devinavery> When you modify changes again use "git commit --amend -s" that should add the change ID and your sign off into the same commit
14:39:42 <Neel_B_> added
14:39:45 <Neel_B_> okay
14:39:52 <devinavery> pulling in the new code now
14:39:54 <Neel_B_> removing is delete draft change ?
14:40:16 <devinavery> There should be an option to "abandon" the draft
14:41:38 <devinavery> Ok. I built your new code and it compiled and the tests ran with no problem
14:43:41 <Neel_B_> deleted other two
14:44:15 <Neel_B_> i was getting errors  :\
14:44:56 <regXboi> short call - I'm back
14:45:02 <regXboi> I see there is a new commit
14:45:03 <regXboi> cool
14:45:19 <devinavery> Ok - regXboi: we ended up generating a third commit - just using that one now
14:45:26 <devinavery> Neel_B has removed the other two
14:45:34 <devinavery> I was able to pull in the new code compile and run tests with no problem
14:45:57 <devinavery> Neel_B: when you run "mvn clean install -DskipTests" my first question is does that run successfully?
14:46:08 <regXboi> catching up now
14:46:18 <devinavery> if so, then lease run mvn clean install and paste the output and failure to a paste bin for us to review
14:46:28 <devinavery> I need to step away for 2 minutes
14:47:00 <Neel_B_> http://pastebin.com/xZGLfdzM
14:47:22 <regXboi> so that is the pastebin from sal-xpath
14:47:44 <regXboi> can you go back to controller and run "mvn clean install -DskipTests" and does it pass?
14:48:54 <Neel_B_> no need to change sal-parent's pom  to add sal-xpath
14:48:56 <Neel_B_> ?
14:49:52 <Neel_B_> running
14:50:10 <devinavery> back
14:51:17 <devinavery> Neel_B: eventually we will want to change sal-parent but for right now you do not need to change it to get this test running
14:52:28 <regXboi> devinavery
14:52:40 <regXboi> I'm pretty sure the problem with the tests is in the paxexam configuration
14:53:07 <regXboi> I'm trying to find where/how I can make sure paxexam is looking at the local maven repo
14:53:53 <devinavery> I would have guessed (and perhaps I am wrong here) that it uses your local repo as a proxy / cache
14:53:59 <devinavery> So I would have thought it only looks there
14:54:16 <devinavery> Probably worth checking first that the artifact is actually installed there...
14:54:50 <devinavery> Neel_B: can you check your local repository (~/.m2/repository/org/opendaylight/controller/ etc and make sure you can find your newly compiled bundle?
14:55:08 <regXboi> devinavery: I can and have and I get the same error
14:56:00 <devinavery> Ok. Let me recompile my entire controller... just incase I have something bogus in my cache
14:56:08 <regXboi> I'm doing that now
14:56:37 <regXboi> I think the question is do you have a settings.xml that is coming into play?
14:57:21 <devinavery> if you run "mvn help:effective-settings" that will print out what your settings are
14:57:51 <regXboi> now *that* is interesting
14:58:13 <devinavery> This is what my output is: basically points to my local repo
14:58:14 <devinavery> http://pastebin.com/86Kd8Vb9
14:58:54 <regXboi> aha
14:58:57 <regXboi> ok I have it working now
14:59:06 <devinavery> Oh. Great. What was the trick?
14:59:22 <regXboi> so we may need to rethink the pom
14:59:34 <regXboi> what I found was that I *didn't* have the jar file in the local m2
14:59:40 <regXboi> because the tests weren't passing
14:59:51 <regXboi> once I ran with skipTests and got the jar in
14:59:57 <regXboi> then all is better
15:00:08 <devinavery> Oh.. chicken and the egg?? :) let me try that then
15:00:14 <regXboi> and we lost Neel
15:00:40 <regXboi> and I get a comparison Failure (but I think that's on the child)
15:00:50 <devinavery> Bingo
15:00:56 <devinavery> I reproduced the error
15:01:03 <regXboi> :)
15:01:10 <devinavery> So I guess Pax-Exam is not smart enough to take the jar from the current bundle...
15:01:18 <devinavery> That seems odd...
15:01:52 <regXboi> ok... so I'm commenting out a few tests
15:01:59 <regXboi> to get back to the original toaster model
15:02:02 <regXboi> and...
15:02:20 <regXboi> oh yeah, I had to hardcode dependencies as well :(
15:02:34 <regXboi> and all is good
15:02:48 <regXboi> so I can say now that we can make this available
15:02:53 <regXboi> with some caveats
15:03:51 <regXboi> and I think we can link it into sal-parent as well
15:03:57 <regXboi> and add that to the next version of the patch
15:04:26 <devinavery> Ok. So wait.. did you just comment out the tests in the toaster so that it would basically skip the pax-exam test?
15:04:40 <regXboi> no, I commented out the tests on the child
15:05:09 <regXboi> because those aren't part of the standard toaster model
15:05:33 <regXboi> in the version of ToasterTest.java I'm looking at I'm talking lines 223-227
15:06:02 <regXboi> and that's because I've not caught up to the new patch
15:06:13 <regXboi> Neel did that already for me in the latest patch
15:06:54 <devinavery> ahh. Ok. Understood
15:07:21 <devinavery> So we still have the problem where if someone is building this bundle for the first time with "mvn clean install" it will fail... right?
15:08:00 <Neel_B> hey devinavery
15:08:10 <Neel_B> regXboi my net got disconnected
15:08:20 <regXboi> we notices
15:08:23 <regXboi> er noticed
15:08:31 <regXboi> but I'm pretty sure we've run everything down
15:08:34 <regXboi> devinavery: yes
15:08:44 <regXboi> I'd like to verify that the new patch compiles
15:08:50 <regXboi> and then make that as a note and carry on
15:09:29 <regXboi> I'm getting a compile error on the new branch
15:10:29 <regXboi> is anybody else seeing this?
15:11:04 <devinavery> On the code from 10173?
15:11:08 <regXboi> yes
15:11:10 <devinavery> I am not seeing any compile errors there
15:11:23 <regXboi> odd... I'm getting a compile error on line 121 of ToasterTest.java
15:11:39 <regXboi> about not being able to find a symbol, but no symbol name
15:13:40 <regXboi> you know what
15:13:42 <regXboi> let's move on
15:13:53 <regXboi> because it's now working for me
15:14:05 <regXboi> so I'm going to assume I was doing something stupid in the file system
15:14:18 <Neel_B> regXboi: running -DskipTests
15:14:26 <regXboi> on the main controller?
15:14:30 <Neel_B> yeah
15:14:35 <regXboi> ok
15:14:57 <Neel_B> already halfway
15:15:32 <regXboi> so... I think you can solve your problem in sal-xpath by doing skipTests there too
15:15:42 <regXboi> and then when you run it again, without skipTests it will work
15:16:03 <regXboi> at least that's how I solved the same error code on my system
15:16:04 <Neel_B> isn't it an issue for someone new using it ?
15:16:19 <devinavery> regXboi: this issue must be why the integration tests were split out into different bundles. Pax-exam can load the source code from the same bundle it is running in
15:16:26 <Neel_B> may be because we are calling the bundle inside itselp
15:16:38 <regXboi> devinavery: that is very likely true
15:16:42 <Neel_B> itself*
15:16:54 <regXboi> devinavery: *but* I'm not sure we have time to fix that anymore
15:17:03 <regXboi> as the project period is ending today
15:17:18 <regXboi> I mean, folks can work on it going forward of course :)
15:17:23 <devinavery> regXboi: agree - just means we need to put a note in there and that we can enable this project to compile by default (since it won't)
15:17:41 <Neel_B> i will finish it
15:17:48 <Neel_B> regXboi for sure.. :)
15:18:01 <regXboi> well, I think the right idea is to split out the test into sal-xpath-it
15:22:18 <regXboi> and yes, I've already done it :)
15:22:25 <regXboi> so I can tell you how
15:22:51 <regXboi> chapter and verse:
15:23:04 <regXboi> 1) in md-sal, mkdir sal-xpath-it
15:23:15 <Neel_B> regXboi:
15:23:19 <Neel_B> passed
15:23:28 <regXboi> cool! 2) in md-sal, cp -r sal-xpath/* sal-xpath-it
15:23:38 <regXboi> 3) in sal-xpath, rm -rf src/test
15:23:51 <regXboi> 4) in sal-xpath, edit pom.xml and remove the pax exam plugin
15:23:58 <regXboi> 5) in sal-xpath-it, rm -rf src/java
15:24:11 <Neel_B> okay
15:24:13 <regXboi> 6) in sal-xpath-it, edit pom.xml and add dependency to sal-xpath
15:24:18 <Neel_B> let me try those things
15:24:23 <regXboi> and then you can build sal-xpath without failing
15:24:30 <regXboi> and sal-xpath-it will run the tests
15:24:58 <regXboi> and 7) edit md-sal/pom.xml and add sal-xpath and sal-xpath-it in it's own block under xsql (testing that one now)
15:25:25 <devinavery> Hey Guys. I need to step away for a bit. Neel_B I am happy to bring your code in and compile it once you have the -it test broken out etc
15:26:09 <devinavery> Just up load a new patch (this time you can upload it public by pushing to HEAD:refs/for/master ) and I will check it out
15:28:27 <Neel_B> regXboi: are there any dependencies for the sal-xpath
15:28:28 <Neel_B> ?
15:28:37 <Neel_B> or i should remove all ?
15:28:39 <devinavery> regXboir and Neel_B - you guys should both be chairs on the meet bot. Please update it with final comments before
15:28:50 <regXboi> no... leave the dependencies alone
15:28:50 <Neel_B> okay sure
15:28:56 <regXboi> just remove the pax-exam plugin
15:29:13 * devinavery is walking away for a while
15:33:21 <Neel_B> okay xpath working fine
15:33:27 <Neel_B> changed xpath-it tooo
15:33:41 <regXboi> try that one now
15:34:07 <Neel_B> we have to change name in pom too ?
15:34:14 <Neel_B> for xpath-it ?
15:34:42 <Neel_B> remove packaging bundle?
15:35:27 <Neel_B> regXboi: ?
15:35:42 <regXboi> give me a sec
15:36:01 <regXboi> you can try it
15:36:03 <regXboi> I didn't
15:36:06 <regXboi> but I probably could have
15:38:39 <regXboi> it should work
15:40:22 <Neel_B> regXboi: same error as you got
15:40:23 <Neel_B> :\
15:40:30 <regXboi> which error is that?
15:40:30 <Neel_B> line 121
15:40:59 <regXboi> did you add the dependency to sal-xpath in the pom.xml?
15:41:32 <Neel_B> yeah i did
15:41:32 <Neel_B> add
15:42:00 <regXboi> so, I found the problem was that I switched windows and was in a stale file system
15:42:27 <regXboi> so I changed up a directory and back down and got to the correct i-node
15:43:08 <Neel_B> lemme try that
15:47:11 <Neel_B> i guess its working
15:47:15 <Neel_B> running tests
15:47:26 <regXboi> it should run two of them
15:49:29 <Neel_B> 1 test isfailing
15:49:32 <Neel_B> lemme check
15:50:58 <Neel_B> okay it is taking my toaster
15:51:07 <Neel_B> so it should fail
15:51:18 <Neel_B> if it takes the old taoster it passes
15:51:32 <Neel_B> regXboi: how to get the old taoster
15:51:54 <regXboi> how is it taken your toaster?
15:53:15 <Neel_B> i haven't changed anything in toaster
16:08:39 <regXboi> ah ok
16:12:27 <regXboi> so now you should be able to change md-sal/pom.xml
16:12:33 <regXboi> and have it all build
16:14:18 <Neel_B> regXboi:
16:14:24 <Neel_B> i am not able to ammend ?
16:14:33 <Neel_B> it is creating new gerrit
16:15:10 <Neel_B> but when i changed the commit -id to the  same 10173 it says rejected
16:15:16 <Neel_B> i mean changeid
16:15:49 <regXboi> when you did commit did you do commit --apend as devinavery suggested?
16:16:46 <regXboi> er I mean --ament
16:16:50 <regXboi> ACK
16:16:57 <regXboi> er I mean git commit --amend
16:19:30 <regXboi> Neel_B, Neel_B_ did you get that?
16:19:40 <Neel_B_> i am trying
16:19:48 <Neel_B_> will ping you
16:20:00 <Neel_B_> first thing
16:20:01 <regXboi> so when I do a git commit --amend, I find a bunch of files need to be added removed
16:20:10 <regXboi> yes?
16:21:03 <Neel_B_> okay lets keep that aside for a second
16:21:10 <Neel_B_> what should i add in md-sal pom
16:21:31 <Neel_B_> <bundle>sal-xpath</bundle> ?
16:21:34 <Neel_B_> right ?
16:21:36 <regXboi> no
16:21:53 <regXboi> down on line 81 (after sal-dom-xsql and the blank line
16:21:56 <regXboi> I'd add the following:
16:22:04 <regXboi> <!-- Xpath -->     <module>sal-xpath</module>     <module>sal-xpath-it</module>
16:22:07 <regXboi> that's four lines
16:22:10 <regXboi> the comment
16:22:14 <regXboi> two module lines
16:22:16 <regXboi> and a blank line
16:22:41 <regXboi> and then you are hooked into the whole build process
16:25:04 <Neel_B_> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.12:check (default) on project sal-parent: Failed during checkstyle execution: There are 1 checkstyle errors. -> [Help 1]
16:25:19 <regXboi> did you use tab?
16:25:38 <regXboi> does a line end with whitespace?
16:27:18 <Neel_B_> retrying
16:28:46 <Neel_B_> that error gone let it compile
16:28:55 <regXboi> ok, it may fail
16:28:57 <regXboi> depending
16:29:11 <regXboi> sometimes I need to add -DskipTests for md-sal to build
16:29:30 <regXboi> but... so long as the refactor shows you in the list, you are good
16:33:11 <Neel_B_> regXboi: can you sum up all at once ?
16:33:19 <Neel_B_> mean while its compiling
16:33:31 <regXboi> so... if md-sal succeeds, great!
16:33:49 <regXboi> but if md-sal fails, then you'll need to go back and look at the error
16:33:58 <Neel_B_> it'snot going to on my system
16:34:09 <Neel_B_> because it takes the modified toaster
16:34:15 <Neel_B_> and it returns error
16:34:24 <Neel_B_> if run on normal toaster it passes
16:34:33 <regXboi> use the normal toaster
16:34:36 <regXboi> don't change that
16:35:25 <Neel_B_> i already changed a lot for the testting right
16:35:27 <Neel_B_> :
16:36:04 <regXboi> ok, let's back up
16:36:14 <regXboi> when you say the modified toaster, what files are you talking about?
16:41:12 <Neel_B_> opendaylight toaster.java
16:41:17 <Neel_B_> i will change it back
16:41:25 <regXboi> yes, that needs to be left alone
16:42:35 <regXboi> now, on my system without -DskipTests, building under md-sal fails at sal-rest-connector
16:43:10 <regXboi> but if I look at the reactor summary, I see that sal-xpath and sal-xpath-it are SKIPPED, which is good, that means they are part of the build
16:43:11 <Neel_B_> still running
16:43:21 <regXboi> so then if I build with -DskipTests they pass
16:58:24 <Neel_B> regXboi:  devinavery
16:58:41 <Neel_B> both sal-xpath and sal-xpath -itare passing
16:58:49 <Neel_B> are compiling with out errors
16:59:03 <Neel_B> and tests are passing on changing the tooaster back to normal
16:59:26 <regXboi> do you have the md-sal/pom.xml changes as well?
16:59:31 <devinavery> awesome
16:59:45 <Neel_B> everything sorted out
16:59:49 <regXboi> if so, then let's do a git commit --amend from md-sal directory
17:00:03 <regXboi> so that we can see what files need to be added and removed for the amended commit
17:00:06 <Neel_B> in 2 mins
17:00:21 <Neel_B> re running from md-sal once again to check
17:00:47 <Neel_B> if that passes every thing is done
17:04:26 <Neel_B> success
17:04:30 <regXboi> :)
17:09:43 <Neel_B> where to push
17:09:53 <Neel_B> drafts or public
17:10:00 <regXboi> what did git commit --amend show you?
17:10:03 <Neel_B> if public command ?
17:11:30 <Neel_B> http://pastebin.com/nKPfVPX5
17:12:28 <regXboi> and go ahead and push it into drafts
17:12:35 <regXboi> so we can make sure it gets there
17:14:08 <Neel_B> A potential Change-Id was found, but it was not in the footer (last paragraph) of the commit message.
17:14:13 <Neel_B> this is what i got
17:16:10 <regXboi> so... when I set up git commit --amend, this is the message that I get: http://pastebin.com/wrEynGfp
17:16:21 <regXboi> did you see something like this for editing the commit message?
17:19:41 <Neel_B> i did
17:19:45 <Neel_B> but not that way
17:20:11 <Neel_B> [DO NOT MERGE] Initial code prototype for XPath query capabilities on MD-SAL
17:20:16 <Neel_B> this line was not there
17:20:40 <regXboi> Then I'm at a loss for what is happening
17:20:53 <regXboi> because that should be there for amending the commit
17:21:04 <regXboi> devinavery: are you available to take over for me and help with getting the commit in?
17:21:16 <regXboi> I have a meeting to go to in 10 and I won't be back for a couple of hours
17:21:23 <devinavery> Sure can
17:21:32 <regXboi> thanks
17:23:30 <devinavery> Ok. Neel_B. Can you run "git log" and send the output
17:23:36 <Neel_B> okay
17:24:12 <Neel_B> http://pastebin.com/JGp7aySj
17:26:16 <devinavery> That is what you get when you run git log?
17:26:21 <devinavery> Seems... strange.
17:26:50 <devinavery> Is there more than just these few lines?
17:27:17 <devinavery> For example I have: http://pastebin.com/9nxq23NT
17:27:54 <Neel_B> the remaining are others
17:27:57 <Neel_B> not mine
17:28:10 <devinavery> Ok. Please paste a couple of these others just so I can see the entire content
17:28:28 <devinavery> And if you can keep formatting etc similar to mind
17:29:17 <devinavery> similar to mine**
17:29:52 <Neel_B> http://pastebin.com/FS1uBdCd
17:31:35 <Neel_B> if its okay can i create a new commit  and push it to new gerrit remove the old one ?
17:31:39 <devinavery> Did you do a head reset again? It looks like we lost the history of your commit..
17:32:02 <devinavery> never mind
17:32:05 <devinavery> Its actually there.
17:32:15 <devinavery> Ok so we lost the message for what ever reason, but that in theory should affect anything
17:32:35 <devinavery> Ok. So when you do a "git commit --amend" what do you see for output?
17:33:20 <Neel_B> http://pastebin.com/fYS8Nkbk
17:34:05 <devinavery> Ok. Please replace lines 1->4 in your commit message with lines 5->8 on my commit message
17:34:27 <devinavery> sorry - lines 5-8 of my paste bin here: http://pastebin.com/9nxq23NT
17:36:47 <devinavery> Once you do that you should be able to push the draft again
17:37:38 <Neel_B> new gerrit
17:37:42 <Neel_B> :\
17:37:57 <devinavery> Man - we really are not having luck pushing patches...
17:38:31 <Neel_B> lets stike with this
17:38:33 <Neel_B> ?
17:38:37 <Neel_B> stick*
17:38:43 <Neel_B> https://git.opendaylight.org/gerrit/#/c/10180/
17:38:49 <devinavery> looking
17:38:57 <devinavery> Need permissions
17:39:15 <Neel_B> yeah
17:39:16 <Neel_B> given
17:39:53 <devinavery> Alright.. this is probably fine. Let me pull in this gerrit and make sure everything is there
17:40:07 <Neel_B> okay
17:40:12 <Neel_B> i have to eat
17:40:20 <Neel_B> can you make it fast :\
17:40:32 <devinavery> doing it right now
17:40:35 <Neel_B> and can i delete the old one ?
17:41:36 <devinavery> Why did you modify restconf documented exception?
17:41:54 <Neel_B> Which one ?
17:42:05 <devinavery> https://git.opendaylight.org/gerrit/#/c/10180/1/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/RestconfDocumentedException.java
17:42:50 <Neel_B> i have no idea
17:42:59 <Neel_B> i didn;'t even touch it
17:43:25 <Neel_B> may some resetting and amending added that file :\
17:43:31 <devinavery> Ok. So we accidentally checked that file in.
17:43:51 <devinavery> If you want to break and get dinner etc this is something that we can try and handle later
17:44:10 <devinavery> Basically we need to reset the checking and check in again without that file
17:44:30 <Neel_B> okay i will finish it off
17:44:34 <Neel_B> no problem
17:44:41 <Neel_B> first i reset
17:44:43 <Neel_B> right ?
17:44:50 <Neel_B> or i just remove that
17:45:05 <Neel_B> git rm --cached <That file>
17:45:13 <devinavery> Yeah. I think that should do the trick
17:45:17 <Neel_B> then git commit --amend -s
17:45:27 <Neel_B> then git push
17:45:31 <Neel_B> to drafts
17:45:38 <Neel_B> that's it right ?
17:45:40 <devinavery> yup
17:49:10 <Neel_B> done
17:49:51 <Neel_B> devinavery: https://git.opendaylight.org/gerrit/#/c/10180/
17:50:03 <Neel_B> success on this
17:50:22 <devinavery> Yeah! We have to patches. :) Ok.. Only problem is that we are now deleting the RestconDocumentException - so that had an undesired affect.
17:51:14 <Neel_B> how to do that
17:51:23 <devinavery> I think we need to do this.
17:51:35 <devinavery> git reset --soft HEAD~1
17:51:51 <devinavery> Then if you run git status you should see all of the files listed as being checked in again
17:52:02 <Neel_B> okay
17:52:23 <devinavery> then we need to remove that file from the being staged
17:52:28 <devinavery> Need to look up that command . one second
17:53:16 <devinavery> ok. When you do git status does it show the RestConfDocumentedException file?
17:54:12 <devinavery> Then I *think* you would run git rm --chached not hat file.
17:54:33 <devinavery> When you run git status it should show up under untracked files and NOT be listed as deleted in the of "Change to be committed"
17:54:44 <devinavery> Actually I take that back.. that didn't work.. sorry.
17:55:40 <devinavery> Ok. The command is "git reset head <filename>
17:56:25 <Neel_B> can i pull from that gerrit ?
17:56:48 <Neel_B> some where else and deal with it properly
17:57:24 <devinavery> I think so...
17:57:33 <devinavery> But that may not be necessary
17:57:43 <devinavery> What does "git status" show you right now?
18:00:21 <Neel_B> i messed up somehow
18:00:48 <Neel_B> i will completely sort it out and i will ping you
18:00:55 <devinavery> Ok. Sounds good.
18:01:16 <Neel_B> my brain is not working properly
18:01:20 <devinavery> You can create a fresh workspace. And then using the cherry pick command available through the UI to download it
18:01:29 <devinavery> And then modify it
18:01:30 <devinavery> Sounds good.
18:01:32 <devinavery> Have a good night
18:10:28 <Neel_B> devin
18:10:30 <Neel_B> you here ?
18:10:40 <devinavery> I am - on a call. Did you fix?
18:10:49 <Neel_B> new work space
18:10:55 <devinavery> ok
18:11:01 <Neel_B> i did use the cherrypick
18:11:05 <Neel_B> to get the code
18:11:22 <devinavery> Ok
18:11:44 <Neel_B> but the git log has someothers commit
18:11:51 <Neel_B> so how do i push patch to it ?
18:12:03 <devinavery> When you do git log what is the first item (at the top)?
18:12:22 <Neel_B> Merge: be88c93 1f5ea7d Author: Alessandro Boch <aboch@cisco.com> Date:   Fri Aug 22 15:53:59 2014 +0000      Merge "Configuration service uses an inconsistent hashcode in the clustered data structure"
18:12:28 <devinavery> Ok.
18:12:35 <devinavery> When you do git status what do you see?
18:12:58 <Neel_B> only the files that are to be pushed
18:12:59 <Neel_B> nothing else
18:13:32 <devinavery> Ok. Do you see the RestconfDocument exception file there?
18:14:07 <Neel_B> no
18:14:14 <Neel_B> i reset it
18:14:59 <devinavery> Ok. Great
18:15:12 <devinavery> Ok. Then do simple git commit -s
18:15:17 <devinavery> Note NO --amend
18:15:21 <devinavery> Then add the change ID in and push it
18:18:38 <Neel_B> add the change id ?
18:19:27 <Neel_B> how do i do thath
18:19:34 <Neel_B> i don't want to mess this up
18:19:35 <devinavery> Paste it into the commit message
18:19:42 <devinavery> Before the sign off
18:20:29 <devinavery> You want to paste the entire thing as you copy from the gerrit ticket
18:20:33 <Neel_B> https://gist.github.com/neel1438/c0e5fc21b2b705c7778b
18:20:47 <Neel_B> this is the out put of git commit -s
18:20:48 <devinavery> Ok. Hold on
18:21:06 <devinavery> Remove lines 6,7,8 9,10
18:21:13 <devinavery> Remove the leading spaces on line 3 / 4
18:25:37 <devinavery> I am starting a meeting in 5 minutes and will not be able to continue chatting
18:25:54 <devinavery> Hopefully that works. If it does end up pushing a new draft it is not the end of the world. Hopefully it won't though
18:37:11 <Neel_B> devinavery: that did not work
18:37:23 <Neel_B> got a new gerrit
18:38:11 <Neel_B> https://git.opendaylight.org/gerrit/#/c/10183/
18:38:15 <Neel_B> this is final i guess
18:38:32 <Neel_B> deleting all the old ones
18:38:39 <Neel_B> only thing available
18:38:44 <Neel_B> is https://git.opendaylight.org/gerrit/#/c/10183/
18:39:42 <Neel_B> Please review and mail me good day :)
14:20:47 <edwarnicke> Karaf Happy Hour at 7:30am PST on #opendaylight-meeting - come out and get help with your karaf features!
15:04:11 <dkathayat> Hi Neel_B and evanz.
15:04:57 <evanz> hi
15:06:09 <dkathayat> evanz: Neel_B and me are interested in attending the Forum. Are you as well?
15:12:28 <evanz> I'm not sure yet, it's going to be a busy semester
15:16:40 <phrobb> Hey guys.  Who all is thinking about trying to come to the dev design forum in Santa Clara at the end of  Sept?  I'll get you connected to have an invite to the event and will help in any other way I can
15:20:41 <Neel_B> phrobb:  i will be attending
20:15:27 <evanz> edwarnicke: who did you mention were working on snmp? I'd like to chat with them
22:04:10 <amit_mandke> @djx hi, you there?
22:04:20 <djx> yep
22:04:58 <amit_mandke> wanted to check with you on https://git.opendaylight.org/gerrit/#/c/10413/
22:05:14 <amit_mandke> and https://git.opendaylight.org/gerrit/10412
22:05:38 <djx> sure, what's up?
22:06:55 <amit_mandke> I thought it is all right if topology manager is removing a node it should also remove links that originate from it
22:07:11 <amit_mandke> or even that has it as destination
22:07:34 <amit_mandke> so I dont see a reason to change that manager. (just a thought)
22:08:21 <amit_mandke> I thing HT can remove a link if it exist if not it should only remove the node? Isn't that enough?
22:10:21 <djx> let me recheck the code
22:10:33 <amit_mandke> ok
22:14:28 <djx> no, I don't think it is correct for TM to remove stuff that isn't their
22:15:30 <djx> and if he removes links that were not created by him, the hostsAttachedToNode method doesn't work
22:17:31 <djx> which means HT won't find which hosts are "orphans"
22:17:45 <djx> and therefore eliminated them from MD-SAL
22:21:50 <djx> amit_mandke ^
22:35:48 <djx> and I don't know why jenkins is failing
22:54:53 <evanz> hi djx
00:37:47 <colindixon> hey djx and evanz, I’m around at this point
00:37:53 <colindixon> well, actually I’m going to wande off this second
00:37:58 <colindixon> but I’m around this week
00:38:41 <djx> lool
20:19:16 <amit_mandke> @evanz or @Collin any idea on Andre's availability? I wanted to discuss further on the current patches he has submitted
20:20:51 <tykeal> y'all aware that you've had a meeting running since sometime on 2014-08-22?
20:27:26 <tykeal> #endmeeting