14:36:26 <edwarnicke> #startmeeting Karaf Happy Hour
14:36:26 <odl_meetbot> Meeting started Thu Sep  4 14:36:26 2014 UTC.  The chair is edwarnicke. Information about MeetBot at http://ci.openstack.org/meetbot.html.
14:36:26 <odl_meetbot> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:36:26 <odl_meetbot> The meeting name has been set to 'karaf_happy_hour'
14:36:26 <vasya10> edwarnicke: none..
14:36:30 <tbachman> I think it just defaults to that until you set a topic
14:36:31 <edwarnicke> #topic Status
14:36:32 <edwarnicke> OK
14:36:34 <tbachman> (or that’s what I’m guessing)
14:36:40 <edwarnicke> Where are folks?
14:36:43 <tbachman> do we info in again then?
14:36:59 <xsited> #info thomas packetcable
14:37:01 <tbachman> you’ll need to rechair as well
14:37:05 <tbachman> #info tbachman for Group Based Policy
14:37:22 <gzhao> #info gzhao for release
14:37:32 <rafat> #info rafat odl-sdni app
14:37:33 <xsited> final integration hurdle.  assets in from jenkins to nexus.  good.  remove .m2/org/opendaylight. build integration.  fail integration build looking for feature assets in defaultlocal.  is there a remedy for this?
14:37:44 <edwarnicke> #info edwarnicke for incompetence in operating meetingbot
14:37:51 <tbachman> lol
14:37:56 <edwarnicke> #chair tbachman gzhao devinavery
14:37:56 <odl_meetbot> Current chairs: devinavery edwarnicke gzhao tbachman
14:38:01 <tbachman> #info shame on tbachman for misleading edwarnicke
14:38:04 <edwarnicke> OK... where are folks?
14:38:45 <gzhao> xsited: I think ChristineH has the same issue
14:39:26 <gzhao> #info PCMM fail integration build looking for feature assets in defaultlocal.
14:39:28 <tbachman> #info Group Based Policy: working on getting the config file to build with feature using clean .m2 (locally)
14:40:03 <edwarnicke> xsited: Do you have dependencies in features/pom.xml for each <bundle> <repo> and <configfile> in your features.xml?
14:40:10 <edwarnicke> xsited: And what is your specific error?
14:40:20 <edwarnicke> xsited: And do you have a gerrit of what you are working on?
14:40:22 <xsited> gzhao: i could finish today with some help on that one.
14:40:29 <edwarnicke> ChristineH: How are you doing?
14:40:37 <edwarnicke> xsited: Then we'll get you help :)
14:40:42 <edwarnicke> xsited: Because that's who we are
14:41:05 <ChristineH> gzhao, xsited: In snmp4sdn's jenkin merge's configuration, I set to skip tests so that snmp4sdn's feature can be built and uploaded to nexus successfully.
14:41:35 <gzhao> ChristineH: I notice initially your integration build has error with defaultlocal cannot find, did that get resolved
14:41:38 <edwarnicke> ChristineH: Don't do that
14:41:50 <edwarnicke> ChristineH: integration will not take a patch bringing you in without a reference to running tests on merge
14:42:02 <edwarnicke> ChristineH: lets figure out how to fix your features ;)
14:42:13 <ChristineH> edwarnicke: that's true, agree not to do that :)
14:42:23 <edwarnicke> ChristineH: :)
14:42:33 <edwarnicke> ChristineH: What errors are you getting in building your features?
14:43:09 <edwarnicke> tbachman: Where are you/
14:43:10 <edwarnicke> ?
14:43:31 <tbachman> info’d above, but: “Group Based Policy: working on getting the config file to build with feature using clean .m2 (locally)”
14:43:42 <ChristineH> edwarnicke: test failure when building the feature
14:44:06 <tbachman> It works if I run mvn clean install in my project at the top level, then mvn clean install from feature dir
14:44:18 <tbachman> but with a clean .m2, it complains about my config file
14:47:04 <edwarnicke> ChristineH: What are the specific failures
14:47:13 <edwarnicke> tbachman: What specific isssues are you hittting?
14:47:16 <ChristineH> edwarnicke: the erorr is pasted here https://git.opendaylight.org/gerrit/#/c/10700/, gzhao provided me the fix from lisp who encountered the same problem before. But not yet solved in snmp4sdn.
14:47:25 <edwarnicke> xsited: How can we help you? :)
14:49:15 <xsited> ed: yes please.
14:49:37 <edwarnicke> ChristineH: Have you tried the fix?
14:50:05 <radhika> Radhika from sdninterfaceapp.. I have one query in features/pom.xml..
14:50:46 <radhika> is it mandatory to include <!--dependency>       <groupId>org.opendaylight.yangtools</groupId>       <artifactId>features-test</artifactId>       <version>${feature.test.version}</version>       <scope>test</scope>     </dependency-->
14:51:15 <xsited> ed: as stated above with gzhao i need help with failing integration build looking for assets on defaultlocal with .m2 removed
14:51:23 <ChristineH> edwarnicke: yes, I tried. The method from the fix seems to be excluding a specific test in dependency bundles
14:51:42 <tbachman> edwarnicke: http://pastebin.com/iCfKaduS
14:51:53 <xsited> ed: minor gerrit merge issue as well
14:51:54 <edwarnicke> xsited: Did my comment about pom.xml dependencies make sense?
14:52:08 <edwarnicke> ChristineH: What test?
14:52:15 <ChristineH> edwarnicke: I apply this method in my feature's pom.xml, but still have the same error.
14:52:57 <ChristineH> edwarnicke: let me check...
14:53:44 <edwarnicke> ChristineH: And what was the fix you tried?
14:54:43 <xsited> ed: ?
14:55:00 <edwarnicke> xsited: Yes?
14:55:12 <edwarnicke> xsited: Did I drop one of your packets (if so, apologies)
14:55:39 <edwarnicke> xsited: did you want to talk about the test fails, or sort out the merge thing first?  Let me know your prefernce :)
14:55:47 <xsited> ed: i have been dropping my marble all over the floor lately
14:56:01 <ChristineH> edwarnicke: in lisp's fix, exclusion for pax exam native is added in each dependency in the pom.xml, <exclusion><groupId>org.ops4j.pax.exam</groupId><artifactId>pax-exam-container-native</artifactId></exclusion>. So I apply in the same way in my pom
14:56:39 <edwarnicke> Is that in that gerrit?
14:57:14 <xsited> ed: the merge fix will allow me to move forward as it is part for the integration sequence, then integration blocking issue.
14:57:50 <xsited> ed: i am not following, but it seems others are facing a similar issue.  so i will be patient and read
14:58:07 <xsited> ed: yes
14:59:42 <ChristineH> edwarnicke: oh, not yet, since it fails. Let me commit it to gerrit for review :)
15:00:03 <edwarnicke> xsited:  Is this the verify that is failing: https://jenkins.opendaylight.org/packetcable/job/packetcable-verify/20/console
15:00:07 <edwarnicke> ChristineH: thank you :)
15:00:15 <edwarnicke> Hopefully something will jump out at me there :)
15:00:44 <xsited> ed: the point of the last sequence of checks is to get snapshots to nexus.  that looks good from here.
15:02:44 <edwarnicke> xsited: Maybe I'm misreading the output for verify/20... but it looks like the build isn't even starting due to pom file issues: http://pastebin.com/EZH1Pumn
15:04:01 <xsited> ed: yup i fat fingered the artifact id and fixed on the next checkin
15:04:45 <edwarnicke> xsited: Victory :)
15:10:20 <gzhao> ChristineH:  https://jenkins.opendaylight.org/integration/job/integration-master-verify-distributions/org.opendaylight.integration$features-integration/257/testReport/junit/installFeature(org.opendaylight.yangtools.featuretest.SingleFeatureTest)[repoUrl_%20file__opt_jenkins-integration_workspace_integration-master-verify-distributions_features_target_classes_features.xml,%20Feature_%20odl-integration-compatible-with-all%2
15:10:59 <gzhao> ChristineH: I saw you have an integration merge pending https://git.opendaylight.org/gerrit/#/c/10710/
15:11:42 <ChristineH> gzhao: thanks, I noticed it, not yet modify the alphabet ordering as you required
15:12:00 <gzhao> ChristineH: don't worry about that
15:12:20 <ChristineH> gzhao: thanks :)
15:13:01 <gzhao> ChristineH: from the testing failure message, java.io.IOException: Error resolving artifact org.opendaylight.snmp4sdn:features-snmp4sdn:xml:features:0.1.3-SNAPSHOT: Could not find artifact org.opendaylight.snmp4sdn:features-snmp4sdn:xml:features:0.1.3-SNAPSHOT in defaultlocal (file:/opt/jenkins-integration/.m2/repository/)
15:13:19 * edwarnicke poll(xsited, ChristineH )
15:13:25 <gzhao> is that the same failure xsited has
15:13:58 <edwarnicke> gzhao: packetcablepccm depends on snmp4sdn?
15:14:18 <edwarnicke> ChristineH: Is there a gerrit with current features/ directory for snmp4sdn ?
15:14:24 <gzhao> edwarnicke: no
15:14:40 <edwarnicke> ChristineH: Ah
15:14:42 <edwarnicke> Hang on
15:14:46 <edwarnicke> Looking at something
15:15:03 <xsited> gzhoa: yup.  just s/snmp2sdn/packetcable/g   and that is the one.
15:15:37 <edwarnicke> ChristineH: You do not yet have a features-snmp4sdn in nexus: http://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/snmp4sdn/
15:15:46 <edwarnicke> ChristineH: Which is why your integration patch has that error
15:15:55 <edwarnicke> xsited: I suspect its the same root cause :)
15:15:59 <gzhao> edwarnicke: it seems both pcmm and snmp have this test failure
15:16:22 <edwarnicke> ChristineH: Is it the case that you do not have a features/ that verifies yet?
15:16:35 <edwarnicke> xsited: Is it the case you do not have a features/ that verifies yet?
15:16:54 <xsited> ed: yup
15:17:14 <ChristineH> edwarnicke: I just commited the pom with the fix as said earlier, https://jenkins.opendaylight.org/snmp4sdn/job/snmp4sdn-verify/214/
15:17:42 <edwarnicke> ChristineH: Apologies for falling behind the thread :)
15:17:42 <Madhu> morning guys.
15:17:43 <Madhu> anyone know the SFC feature status ?
15:18:01 <edwarnicke> Madhu: paulq is working on it
15:18:08 <edwarnicke> Madhu: SFC meeting is going on now
15:18:15 <Madhu> ChristineH: did the lispflowmapping fix help you ?
15:18:17 <edwarnicke> Madhu: He's pretty close
15:18:20 <Madhu> edwarnicke: okay
15:18:26 <edwarnicke> Madhu: I presume you need him to work closely with shague_ ?
15:18:38 <Madhu> sam added the ovs-sfc feature and am helping him
15:18:49 <Madhu> but sam just went on PTO (i think).
15:18:54 <ChristineH> edwarnicke: woops, I just found I need to commit again using a correct pom.xml
15:18:56 <Madhu> so I might have to take up Sam's stuff
15:18:59 <gzhao> Madhu: morning
15:19:04 <Madhu> gzhao: morning
15:19:13 <edwarnicke> ChristineH: https://jenkins.opendaylight.org/snmp4sdn/job/snmp4sdn-verify/214/ does not appear to be building your features/ directory
15:20:02 <devinavery> Madhu: question for you when you have a minute re features defined in /controller/features/controller/
15:20:09 <ChristineH> edwarnicke: that's right~
15:20:12 <Madhu> devinavery: sure.
15:20:22 <edwarnicke> ChristineH: OK... we need to have that test run
15:20:50 <edwarnicke> ChristineH: Or rather... what is the purpose of the patch if you not building features/ :)
15:20:57 <devinavery> Madhu: Do you know if the features defined in there are suppose to be valid? When I tried referencing them (in my case I was trying to get host tracker) I had a number of issues - mostly due to features being renamed etc, bundle versions etc
15:21:16 <Madhu> lemme check.
15:21:19 <devinavery> Madhu: also found that they are not tested etc. So I was wondering if you know if they are valid, or dead code.
15:21:20 <Madhu> all i have done so far are :
15:21:22 <devinavery> Madhu: thanks
15:21:30 <Madhu> controller/features/base, adsal, nsf
15:21:38 <Madhu> didn't know there is a controller/features/controller :)
15:21:49 <ChristineH> edwarnicke: I missed to add 'features' to build
15:21:59 <ChristineH> edwarnicke: now solving it...
15:22:00 <edwarnicke> ChristineH: :) easy to fix ;)
15:22:14 <Madhu> devinavery: i don't think they are valid and am not even sure who defined them and when it was done :)
15:22:19 <devinavery> Madhu: Ok... so it seems like the controller/features/controller might be dead code then as the features do not work without some major tweaking. :)
15:22:22 <Madhu> devinavery: git log... :)
15:22:30 <Madhu> devinavery: yep. seems like it
15:23:23 <devinavery> Madhu: looking at the history it looks like this was original work. Ok. I will open a bug to remove that code then.
15:23:37 <devinavery> Madhu: Another question then - is there a feature for hosttracker that you are aware of?
15:23:38 * edwarnicke edwarnicke falls to his default stance of wanting dead code deleted but being highly persuadable not to if someone has a reason
15:23:52 * edwarnicke hates purposeless dead code... but purposeful dead code is different ;)
15:23:59 <Madhu> devinavery: there is a problem with adsal bundles.. they are not clean with dependencies
15:24:14 <Madhu> devinavery: mlemay tried hard... but it is difficult to make it work as individual features
15:24:19 <Madhu> devinavery: so it is odl-nsf-managers
15:24:21 <devinavery> edwarnicke: I think in this case the code that is in there is "dead" and should be removed.
15:24:24 <Madhu> all-in or nothing :(
15:24:37 <edwarnicke> Madhu: Are you ok with removing features/controller as dead code?
15:24:41 <Madhu> devinavery: i would check with mlemay before removing it :)
15:24:47 <devinavery> Madhu: Ahh. Ok. so the odl-nsf-managers karaf feature should cover those. Thanks. Just need a starting place. :)
15:24:48 <edwarnicke> xsited: How are you doing?
15:24:54 <Madhu> devinavery: yep.
15:25:09 <devinavery> Madhu: will do - I will verify with mlemay before removing.
15:25:59 <Madhu> devinavery: thanks
15:28:58 <xsited> xsited would like a clean integration build, check in, and check off that box.
15:29:36 <edwarnicke> xsited: Do you have a clean verify on packetcable for your feature?
15:31:06 <edwarnicke> xsited: If not, whats the impediment, so we can clear it :0
15:31:07 <edwarnicke> :)
15:32:10 <edwarnicke> rafat: Are you here for Karaf Happy Hour?  Do you need a hand?
15:32:41 <tbachman> edwarnicke: http://pastebin.com/iCfKaduS
15:33:13 <edwarnicke> tbachman: Looking
15:33:50 <rafat> We have been able to build Karaf successfully..
15:34:08 <edwarnicke> tbachman: Have you built: groupbasedpolicy-controller-config
15:34:17 <edwarnicke> rafat: That is fantastic news :)
15:34:23 <edwarnicke> do you have a patch for integration?
15:34:26 <tbachman> edwarnicke: no. Should I need to?
15:34:27 <rafat> but sill not able to see our feature after giving the command feature:list -i
15:34:34 <edwarnicke> rafat: Ah
15:34:35 <edwarnicke> Ok
15:34:42 <edwarnicke> rafat: Want to figure that out?
15:35:02 <rafat> So am unable to proceed with integration..yes please.
15:35:23 <edwarnicke> rafat: Is your local karaf distribution in master?
15:35:35 <edwarnicke> rafat: And just to make sure I'm not confused, what is your repo?
15:35:39 <rafat> I think so...https://git.opendaylight.org/gerrit/10705
15:35:44 <rafat> sdninterfaceapp
15:36:27 <edwarnicke> rafat: thank you for the link, it makes it much easier to figure things out :)
15:36:37 <edwarnicke> rafat: Do you see your feature in
15:36:41 <edwarnicke> feature:list
15:36:43 <edwarnicke> Without the -i ?
15:36:53 <rafat> No Ed
15:36:58 <edwarnicke> OK
15:37:05 <edwarnicke> Could you pastebin the output if
15:37:07 <edwarnicke> repo-list
15:37:28 <rafat> oh..I cannot do it now..Can try only tomorrow morning..:-(
15:38:05 <edwarnicke> rafat: We need to get you guys into integration today as today is Code Freeze
15:38:36 <edwarnicke> rafat: Let me do this... let me pull down your patch and see what repo-list says
15:41:17 <ChristineH> edwarnicke: I'm confused with the commits in verify and merge jobs :(  Anyway, the latest code and the result of jenkin build is here: https://jenkins.opendaylight.org/snmp4sdn/job/snmp4sdn-merge/125/
15:42:55 <ChristineH> edwarnicke: the fix as mentioned earlier, https://git.opendaylight.org/gerrit/#/c/10781/, is included in it.
15:45:09 <ChristineH> Madhu: sorry for late reply. I tried the fix from lispflowmapping, but still fail :(  https://jenkins.opendaylight.org/snmp4sdn/job/snmp4sdn-merge/125/    https://git.opendaylight.org/gerrit/#/c/10781/
15:47:08 <edwarnicke> rafat: Stay with me :)  Lets see what we can figure out
15:47:18 <rafat> yes Ed.
15:51:14 <edwarnicke> rafat: build fails everywhere on checkstyle issues
15:51:49 <rafat> we are compiling with the command: mvn clean install -DskipTests -Dcheckstyle.skip=true
15:52:09 <edwarnicke> rafat: OK
15:52:17 <edwarnicke> So skipping checkstyles is fine I suppose
15:52:28 <edwarnicke> But skipping tests is probably going to cause issues
15:54:30 <edwarnicke> rafat: Your features do not load at the OSGI level:
15:54:33 <edwarnicke> https://www.irccloud.com/pastebin/wuAZEt39
15:54:41 <edwarnicke> You didn't see it, because of the skipTests
15:54:45 <rafat> oh..
15:54:59 <edwarnicke> Looking quickly at your distro
15:56:17 <rafat> so I need to compile without skipping tests...We have even tried that..Give me a moment, I have Radhika joining in..
15:56:26 <edwarnicke> excellent :)
15:56:30 <edwarnicke> rafat: Can she work on it?
15:56:33 <edwarnicke> rafat: now?
15:56:48 <rafat> Radhika, ca you throw some pointers here ???
15:58:04 <tbachman> edwarnicke: you asked “Have you built: groupbasedpolicy-controller-config”
15:58:13 <tbachman> I haven’t since wiping out my .m2
15:58:15 <radhika> without skipTests also it will pass.. but i commented yangtools feature test in features/pom,xml..
15:58:23 <tbachman> should I need to build this?
15:58:23 <edwarnicke> tbachman: Is it in nexus?
15:58:31 <radhika> is this fine..to compile like this..
15:58:41 <tbachman> nope
15:58:53 <edwarnicke> radhika: I just built features/ in 10705 and it fails
15:59:02 <edwarnicke> https://www.irccloud.com/pastebin/wuAZEt39
16:03:23 <xsited> http://pastebin.com/dxY4YUvd
16:03:31 <edwarnicke> xsited: Looking :)
16:03:42 <radhika> edwarnicke: I cant work now . I d'nt have the environment now.
16:04:04 <edwarnicke> xsited: Which directory are you buidlign that in, and can I see its pom file?
16:04:20 <radhika> But this issue get fix by commenting the feature-list dependency in features/pom.xml
16:04:28 <edwarnicke> radhika: Is there anyone who can work on sdni now... today is the deadline for getting karaf stuff into integration
16:04:30 <Madhu> edwarnicke: when u get a chance : https://git.opendaylight.org/gerrit/#/c/10747/
16:04:41 <radhika> I got it fix today
16:05:07 <edwarnicke> radhika: Could you point me to the gerrit?  or is it on master?
16:05:07 <Madhu> radhika: sorry for jumping in late on this...
16:05:20 <Madhu> radhika: i saw a mistake in the integration gerrit on sdni
16:05:28 <Madhu> radhika: not sure if u guys are talking about that :)
16:05:29 <edwarnicke> Madhu: Better late than never, happy for another helping hand :)
16:05:41 <edwarnicke> Madhu: We are sort of moving in that direction :)
16:05:52 <edwarnicke> I was pointed at an sdni gerrit by rafat
16:05:55 <xsited> ed: integration build with packetcable hacked
16:05:55 <edwarnicke> And was debugging it
16:06:12 <edwarnicke> And I think radhika is trying to tell me I'm looking at the wrong thing
16:06:21 <edwarnicke> Ah
16:06:26 <Madhu> i was looking @ https://git.opendaylight.org/gerrit/#/c/10580/
16:06:40 <Madhu> and patch set 4 seems to have the right fix
16:06:50 <edwarnicke> Madhu: Your context is better than mine then :0
16:07:03 <edwarnicke> xsited: so integration/features ?
16:07:08 <Madhu> radhika: patch set 3 didn't have the features added
16:07:21 <xsited> ed: yup
16:07:28 <Madhu> radhika: in 4, it was added.... so am trying to understand how i can help
16:07:32 <edwarnicke> cool... looking at the error in that context
16:07:35 <Madhu> (if at all there is any help needed)
16:08:01 <edwarnicke> xsited: Did you add a dependency to integration/features/pom.xml for features-packetcable
16:08:02 <radhika> yes madhu was right.. patch 4 is the latest code we uploaded...
16:09:12 <xsited> http://pastebin.com/PgEaFxr1
16:15:41 <radhika> edwarnicke: can you try with the latest code from git..? because we got it success while building it in jenkins today..
16:15:53 <edwarnicke> radhika: I would *love* to :)
16:16:07 <edwarnicke> radhika: I was just confused because rafat was pointing me at a gerrit that wasn't working :)
16:16:17 <radhika> edwarnicke: thanks :) :) :)
16:16:18 <edwarnicke> radhika: That coupled with being really concerned that you guys got in :)
16:17:39 <radhika> We didnt do the integration testing after uploading the code.. she might mentioned that..
16:23:02 <xsited> "patience, grasshopper"
16:23:10 <edwarnicke> xsited: Apologies
16:23:16 <edwarnicke> xsited: Looking
16:23:33 <gzhao> edwarnicke: Madhu if you can merge https://git.opendaylight.org/gerrit/#/c/10580/
16:24:01 <Madhu> gzhao: i cannot :) not a commiter
16:24:48 <edwarnicke> xsited: working hypothesis... typo... looking closer to validate hypothesis (it might be something else)
16:25:43 <gzhao> Madhu: -:(
16:26:06 <edwarnicke> gzhao: I will look at those as soon as I get a breather from folks working on getting their stuff in ;)
16:26:18 <gzhao> edwarnicke: sure, thanks
16:31:22 <edwarnicke> xsited: Could you push a gerrit?
16:34:36 <tbachman> edwarnicke: question on how other projects are managing their configfiles
16:34:44 <edwarnicke> tbachman: ask away :)
16:34:56 <tbachman> the way I’ve set things up is that it’s in a separate dir with a separate pom file
16:35:05 <tbachman> (following things like l2switch, et. al.)
16:35:13 <edwarnicke> Sure
16:35:21 <tbachman> Do I need to build those first, in order for my karaf feature to work?
16:35:23 <edwarnicke> I tend to like that approach personally
16:35:29 <edwarnicke> Ah
16:35:36 <tbachman> I would have thought just building from my karaf dir would have caused that to get built
16:35:38 <edwarnicke> So those config files need to be available in your .m2 yes
16:35:43 <edwarnicke> So if you only have them locally
16:35:52 <edwarnicke> You would need to build them first to populate your local .m2
16:36:04 <edwarnicke> tbachman: Ah, no
16:36:19 * edwarnicke stops to rethink
16:37:33 * edwarnicke tries walking through step by step
16:37:53 <edwarnicke> so when you say your karaf dir, do you mean features/
16:39:12 <tbachman> edwarnicke: sorry — yes, I mean features
16:39:18 <edwarnicke> Ah
16:39:18 <edwarnicke> OK
16:39:21 <edwarnicke> So no
16:39:32 <edwarnicke> but I would expect it to fail the build there
16:39:34 <tbachman> no, as in it won’t cause it to be built
16:39:37 <edwarnicke> if its in your dependencies
16:39:42 <edwarnicke> and not in .m2
16:39:43 <xsited> ed: push the integration build changes?
16:39:43 <tbachman> k
16:39:45 <edwarnicke> and not in nexus
16:39:56 <edwarnicke> xsited: Sure... so I can take a look
16:40:02 <edwarnicke> xsited: I know its not quite working
16:40:04 <xsited> ed: gladly
16:40:09 <edwarnicke> xsited: But I need something to poke at :)
16:41:11 <tbachman> edwarnicke: okay, then am feeling a bit better. I was holding off on doing the integration step b/c I wanted to make sure that the config file set was working, and since it fails with a clean .m2 (as per karaf-step-by-step instructions), that had me worried
16:41:40 <edwarnicke> tbachman: do you have a dependency in your features/pom.xml on the config file?
16:41:49 <tbachman> edwarnicke: would you like me to add a blurb in the karaf-step-by-step that building with a clean .m2 may not work if you’ve set up a config file (or other things) as separate dependencies?
16:41:52 <radhika> edwarnicke: madhu: got success for sdni..?
16:42:02 * tbachman thinks so, but goes off to check.....
16:42:39 <tbachman> edwarnicke: I do
16:42:48 <tbachman> <dependency>
16:42:48 <tbachman> <groupId>org.opendaylight.groupbasedpolicy</groupId>
16:42:50 <tbachman> <artifactId>groupbasedpolicy-controller-config</artifactId>
16:42:51 <tbachman> <version>${project.version}</version>
16:42:53 <tbachman> <type>xml</type>
16:42:54 <tbachman> <classifier>config</classifier>
16:42:55 <tbachman> </dependency>
16:42:56 <tbachman> ^^^ edwarnicke
16:43:12 <tbachman> that’s the dir where I have the separate pom.xml and subdirs that contain the config file
16:44:08 <xsited> ed: pushed.
16:47:04 <edwarnicke> link?
16:47:13 <edwarnicke> tbachman: Looks about right
16:47:51 <tbachman> edwarnicke: so… I guess I’m still confused. I *shouldn’t* build if I don’t have groupbasedpolicy-controller-config in my local .m2?
16:48:03 <tbachman> (s/I/It)
16:51:06 <edwarnicke> tbachman: one moment
16:51:12 <rafat> ed : madhu: Hope sdni is compiling now..
16:51:28 <rafat> As per Radhika's suggestion
16:52:15 <Madhu> rafat: sorry. am still not clear on what the problem is. the jenkins integration is happy and so am I :)
16:52:27 <Madhu> am not compiling it locally
16:53:31 <tbachman> time check — TSC call in 7
16:53:35 <tbachman> we’ll have to eject
16:53:36 <tbachman> :)
16:53:45 <rafat> Madhu: yes..the concern is that feature:list -i did not list our sdniinterfaceapp
16:54:08 <Madhu> rafat: u mean even after patch set 4 ?
16:54:18 <Madhu> rafat: patschest 3 will have that issue. i can see it.
16:54:36 <edwarnicke> tbachman: So... given your description, needing to build groupbasedpolicy-controller-config  is fine
16:54:42 <rafat> Yes..I am talking of local set...also
16:54:57 <tbachman> edwarnicke: does that mean the config file needs to be a separate feature?
16:55:06 <edwarnicke> tbachman: Nope
16:55:07 * tbachman is trying to picture how this works
16:55:09 <tbachman> okay
16:55:18 <edwarnicke> It should in fact be in a feature that brings along all the stuff it needs to configure
16:55:32 <tbachman> k
16:55:41 <edwarnicke> because when its applied, the config subsytem will start looking around for the bundles it needs to do the configuration
16:55:44 <tbachman> thx. I can move on to the integration
16:55:47 <edwarnicke> And if it doesn't find them... well...
16:55:51 <rafat> Madhu: Yes but the next patch upload was for the right poms..So the Jenkin success was there..
16:55:53 <edwarnicke> hulk smash
16:55:57 <tbachman> lol
16:56:29 <rafat> Madhu: Hope you are getting it.Radhika your input please...
16:57:41 <Madhu> rafat: yes. so am seeing the patch and jenkins is happy and am happy :) u want me to try it out manually ? i don't see a value in this case.
16:57:51 <Madhu> edwarnicke: u have any concerns with this patch ?
16:58:21 <rafat> Madhu: No Madhu.Not required..Just needed some confirmation :-)
16:58:30 <rafat> So I guess we are good to proceed now..
16:59:42 <rafat> Madhu: Ed: so I think our Karaf is fine.
17:00:42 <Madhu> rafat: okay. i would think so too. integration team must take care of the next steps
17:01:01 <rafat> Thanks Madhu.
17:01:24 <phrobb> #endmeeting