01:45:19 <edwarnicke> #startmeeting
01:45:19 <odl_meetbot> Meeting started Wed Jan 15 01:45:19 2014 UTC.  The chair is edwarnicke. Information about MeetBot at http://wiki.debian.org/MeetBot.
01:45:19 <odl_meetbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
01:45:37 <edwarnicke> #topic rollcall: who's here for the Hydrogen Release Sync meeting
01:46:00 <dbainbri> #info dbainbri present
01:47:24 <hideyuki> #info Hideyuki Tai present
01:47:37 <edwarnicke> Anyone else?
01:48:18 <edwarnicke> Christine_: Are you here for the meeting? :)
01:48:28 <Christine_> Hi, yes
01:48:46 <Christine_> Sorry being late~
01:49:16 <edwarnicke> No worries :)
01:51:22 <edwarnicke> #topic Agenda Bashing
01:51:41 <edwarnicke> Does anyone have anything they'd like to address first before we start walking down topics (or questions, etc)
01:52:07 <hideyuki> I don't have anything.
01:52:08 <dbainbri> noope
01:52:41 <Christine_> me either
01:52:48 <edwarnicke> Cool
01:53:00 <edwarnicke> #topic Review of Logging Recommendations
01:53:31 <edwarnicke> regXboi was kind enough to prepare a quick draft on logging recommendations: https://wiki.opendaylight.org/view/Draft_Syslog_Level_Settings
01:53:54 <edwarnicke> The idea being... well... we log to much, and we should trim back on how much we log... but it helps to have some recommendations as to when to log at what level
01:54:12 <hideyuki> Ok.
01:54:15 <edwarnicke> Do you guys have any thoughts/feedback/objections to the recommendations on log levels and when to use them?
01:54:45 <dbainbri> debug - method entry / exit?
01:54:54 <dbainbri> really need that level of debug?
01:55:14 <dbainbri> or are those "examples"
01:55:40 <hideyuki> No comments from me.
01:55:44 <edwarnicke> dbainbri: The notion is not to say 'You need to log this' but rather to say 'If you are going to log this, please use debug, not info'
01:55:57 <dbainbri> got it. thx.
01:57:03 <hideyuki> I'll give this page to our engineer, and let them review it.
01:57:14 <edwarnicke> hideyuki: Thank you :)
01:57:35 <edwarnicke> Please feel free to provide any feedback at all, we'd like to get it right, and all of us together will come up with a better solution than one of us :)
01:57:43 <edwarnicke> Christine_: Any feedback/
01:57:44 <edwarnicke> ?
01:58:19 <Christine_> It's fine with me :)
01:58:45 <edwarnicke> Cool
01:59:09 <edwarnicke> The idea will be that once we settle on that, we will have each project go back and try to come in line with the recommendation, so we don't have log polution
01:59:24 <edwarnicke> #topic Dependency Convergance
02:00:00 <edwarnicke> Have you guys seen the email Madhu sent out about setting up a Jenkins Job to upgrade to the latest versions of dependencies?
02:00:31 <hideyuki> Yes, I've seen this mail.
02:00:46 <dbainbri> yes
02:00:54 <hideyuki> And, VTN Project has already created the job: https://jenkins.opendaylight.org/vtn/job/vtn-version-changes/
02:00:55 <Christine_> yes.
02:01:22 <Christine_> snmp4sdn also created that.
02:01:51 <Christine_> and fix the dependencies not the latest
02:02:17 <edwarnicke> #info VTN has created their Dependency Check Job https://jenkins.opendaylight.org/vtn/job/vtn-version-changes/
02:02:24 <edwarnicke> Christine_: Do you have the link for yours?
02:02:33 <hideyuki> Thank you, edwarnicke .
02:02:44 <edwarnicke> hideyuki: Has it run yet, and have you guys upgraded your dependencies yet?
02:02:49 <Christine_> yes, here it is: https://jenkins.opendaylight.org/snmp4sdn/job/snmp4sdn-version-changes/
02:03:10 <edwarnicke> #info SNMP4SDN has created their Dependency Check Job https://jenkins.opendaylight.org/snmp4sdn/job/snmp4sdn-version-changes/
02:03:22 <edwarnicke> dbainbri: What about you guys?
02:03:36 <hideyuki> We've run the job, and no error messages appear.
02:03:46 <edwarnicke> hideyuki: Excellent :)
02:04:06 <dbainbri> we are not really doing anything that needs this right now. we are still mostly exploring ;)
02:04:17 <edwarnicke> #info VTN is reported to be up to date by the Dependency Check Job
02:04:28 <edwarnicke> dbainbri: Apologies...sometimes you get into a pattern :)
02:04:44 <dbainbri> no worries. i am just a fly on the wall.
02:04:50 <edwarnicke> Christine_: What is the state of SNMP4SDN on getting your dependencies up to date
02:05:50 <Christine_> snmp4sdn-version-changes found two dependencies not the latest, and then I updated them in pom.
02:06:07 <Christine_> So all the dependencies are latest now in snmp4sdn.
02:07:05 <edwarnicke> #info SNMP4SDN is reported to be up to date by the Dependency Check Job
02:07:20 <edwarnicke> #topic
02:07:32 <edwarnicke> #topic Cleaning up System.out.println
02:08:16 <edwarnicke> So, we need to clean up our use of System.out.println to use proper loggers instead so we don't wind up with unmanagable output to console
02:08:35 <edwarnicke> I've filed bugs for each project with the results of a quick and dirty grep script I ran
02:09:01 <edwarnicke> For VTN its here: https://bugs.opendaylight.org/show_bug.cgi?id=304
02:09:22 <hideyuki> Thank you, I checked your mail and the bug report.
02:09:24 <edwarnicke> For SNMP4SDN its here: https://bugs.opendaylight.org/show_bug.cgi?id=303
02:09:51 <edwarnicke> hideyuki: Thank you, does it look like something you guys could clean up for tomorrow (or do you see any issue with my reporting, as mentioned, it was a quick and dirty script)
02:10:35 <edwarnicke> Christine_: Does it look like something you guys could clean up for tomorrow (or do you see any issue with my reporting, as mentioned, it was a quick and dirty script)
02:11:20 <hideyuki> I think VTN Project can clean up this by tomorrow, edwarnicke .
02:12:23 <edwarnicke> #info hideyuki has committed the VTN project to cleaning up System.out.printlin issues  ( https://bugs.opendaylight.org/show_bug.cgi?id=304 ) by 1/15/2014
02:12:42 <hideyuki> Should we delete System.out.pirntln in test code?
02:13:06 <edwarnicke> hideyuki: To a large extent that's up to you
02:13:22 <Christine_> I'm not quite sure about clean up tomorrow, for snmp4sdn. There are quite many ones.
02:13:28 <edwarnicke> From my perspective, the project has an interest in requesting that you guys clean up System.out.println in stuff that will run in the controller
02:13:39 <edwarnicke> Because that will produce console pollution
02:13:55 <hideyuki> I see. I'll discuss about this with my colleagues.
02:14:26 <edwarnicke> I would suggest that using log rather than System.out.println is a good practice in tests, but I do not think my opinion is the deciding one there.  I think that's up to the VTN committers to decide.
02:14:53 <hideyuki> It seems that we use System.out.println only in test code in VTN Project.
02:14:55 <Christine_> Two days for snmp4sdn to clean up is enough.
02:14:58 <edwarnicke> #info VTN will decide whether or not to clean up System.out.println statements that are in tests but not production code.
02:15:44 <edwarnicke> #info Christine_  has committed snmp4sdn to cleaning up System.out.printlin issues ( https://bugs.opendaylight.org/show_bug.cgi?id=303 ) by 1/16/2014
02:16:43 <edwarnicke> Christine_: I noticed you guys have two third-party projects, expect4j and snmpj for which you've copied the source code into third-party in snmp4sdn, and they contain many many System.out.println statements.
02:16:53 <edwarnicke> Did those come with the original code, or did you guys add them?
02:18:37 <edwarnicke> #info regXboi joins the meeting
02:19:14 <edwarnicke> Christine_: Are you still there?
02:19:20 <Christine_> oh, yes.
02:19:24 <Christine_> wait a moment pls~
02:19:27 <regXboi> on the topic of updating dependency versions, I believe that opendove is now caught up
02:19:50 <edwarnicke> Could you provide the link to your job?
02:20:13 <regXboi> #link https://jenkins.opendaylight.org/opendove/job/opendove-version-changes/
02:20:35 <regXboi> that's verbatim based on Madhu's mail
02:20:49 <edwarnicke> #info openDove has created their Dependency Check Job https://jenkins.opendaylight.org/opendove/job/opendove-version-changes/
02:21:17 <edwarnicke> #info opendove is reported to be up to date by the Dependency Check Job
02:21:20 <Christine_> edwarnicke: Those System.out.println in the third-party projects came with the original code.
02:21:33 <edwarnicke> OK, thank you for letting me know :)
02:21:37 <regXboi> phooey - on the syslog, what's the link for the minutes again?
02:21:53 <edwarnicke> The minutes for this meeting?
02:21:59 <regXboi> yes, that wiki page
02:22:20 <edwarnicke> https://wiki.opendaylight.org/view/CrossProject:Hydrogen_Release_Work
02:22:44 <edwarnicke> Christine_: I've left out the third-party System.out.println from the bug on the theory that they came from the third-party
02:22:46 <regXboi> #info draft syslog levels and uses are available from https://wiki.opendaylight.org/view/Draft_Syslog_Level_Settings
02:23:33 <edwarnicke> regXboi: We looked at them earlier in the meeting, folks were fine, but dbainbri expressed some confusion that we were *requiring* debug logs on every function entry and exit, and hideyuki is going to check with his colleagues and come back with feedback
02:23:42 <edwarnicke> I've added a Feedback section to the page
02:23:57 <edwarnicke> #topic Copyright/License headers
02:24:19 <edwarnicke> Did everyone see the email from phrobb about copyright/license headers in files?
02:24:20 <regXboi> have we considered a jenkins job to check code headers?
02:24:31 <phrobb> and I'm here if there are questions
02:24:31 <Christine_> edwarnicke: thanks, we'll notice all system.out.println in snmp4sdn repo :)
02:24:35 <edwarnicke> regXboi: Sounds like a good idea :)
02:24:38 <regXboi> on the email - I don't think so
02:24:41 <hideyuki> Yes, I've checked the mail about copyright.
02:25:17 <regXboi> edwarnicke: I'll talk with you and Madhu tomorrow about how to "make the jenkins job so"
02:25:45 <edwarnicke> regXboi: Thank you
02:25:52 <regXboi> edwarnicke: welcome
02:26:10 <edwarnicke> #info regXboi is going to consult with Madhu_offline on 1/15/2014 about getting a Jenkins Job going to check copyright/license headers
02:26:48 <hideyuki> We'll check the list in the mail, and will reply to Phil Robb.
02:27:03 <edwarnicke> Thank you :)
02:27:21 <edwarnicke> #info VTN has received copyright/license headers email from phrobb and is on it
02:27:37 <edwarnicke> Christine_: Where do you guys stand with the copyright/license headers?
02:27:49 <edwarnicke> regXboi: You should have email to opendove-dev from phrobb
02:28:18 <regXboi> I'm pretty sure we have correct copyright headers (thanks to ashaikh), but I'll check the email tomorrow
02:28:32 <regXboi> also the copyright needs to be on all files - not just java...
02:29:09 <edwarnicke> regXboi: I agree on the all *feasible* files (sadly, not all file types have good commenting mechanisms :( )
02:29:33 <regXboi> edwarnicke: point accepted
02:29:44 <edwarnicke> #info regXboi from opendove has been notified of copyright/license headers email from phrobb and will follow up with him tomrrow
02:30:07 <phrobb> sounds good
02:30:11 <regXboi> agreed
02:30:13 <edwarnicke> Christine_: Still there?
02:30:23 <hideyuki> agreed.
02:30:47 <edwarnicke> Anything else folks feel we need to cover before we end the meeting?
02:30:50 <Christine_> oh, yes.
02:31:07 <edwarnicke> Christine_: You saw the copyright/license headers email from phrobb ?
02:31:24 <Christine_> we've received mail about Copyright/License Information, will follow it.
02:31:59 <edwarnicke> #info Christine_ from SNMP4SDN has received copyright/license headers email and will follow it
02:32:02 <regXboi> then I think we need one more info and we can call it
02:32:07 <edwarnicke> What?
02:32:15 <regXboi> that was what we needed
02:32:19 <regXboi> that last info
02:32:22 <edwarnicke> #endmeeting