16:28:17 <gzhao> #startmeeting autorelease RC1
16:28:17 <odl_meetbot> Meeting started Mon Sep 15 16:28:17 2014 UTC.  The chair is gzhao. Information about MeetBot at http://ci.openstack.org/meetbot.html.
16:28:17 <odl_meetbot> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:28:17 <odl_meetbot> The meeting name has been set to 'autorelease_rc1'
16:28:22 <edwarnicke> ChristineH: gershon is from defense4all :0
16:28:29 <ChristineH> Hi, all. Sorry for coming late.
16:28:36 <gzhao> just want to record to see if it will help other people
16:28:50 <edwarnicke> gzhao: Many thanks :)
16:28:50 <ChristineH> hi, edwarnicke, gershon ^_^
16:28:56 <gzhao> ChristineH: it is ok, thanks for being here.
16:28:58 <edwarnicke> ChristineH: Its OK... we are here now, that's what matters :)
16:29:30 <gzhao> ok in today's daily meeting, we identify two items.
16:29:41 <gzhao> 1) defense4all version issue
16:29:52 <gzhao> 2) snmp4sdn karaf testing issue
16:30:07 <gzhao> edwarnicke: it seems that you need to work on both on the same time
16:31:09 <gershon> edwarnicke - I am with you on defense4all version issue...:)
16:31:29 <edwarnicke> gershon: Cool :)
16:31:55 <edwarnicke> gershon: So I *think* it should be easy to fix... I *think* if it is acceptable to you then bumping to 1.0.13-SNAPSHOT should do it...
16:32:00 * edwarnicke is open to other ideas :)
16:32:07 <edwarnicke> ChristineH: I pushed https://git.opendaylight.org/gerrit/11195
16:32:07 <gershon> I just would like to understand if adding -SNAPSHOT suffix will actually resolve it or I am missing something...
16:32:10 <edwarnicke> Its not quite working
16:32:14 <edwarnicke> But it solves several issues
16:32:23 <edwarnicke> See the comments inline in the gerrit
16:32:44 <edwarnicke> gershon: Having a SNAPSHOT version should resolve the issue
16:35:38 <gershon> edwarnicke: Ok, great. And other question is "how can I check it locally, before comiting to ODL?"
16:35:40 <edwarnicke> ChristineH: Let me know if the patch makes sense ot you
16:35:55 <edwarnicke> ChristineH: gzhao please note, the patch is not a complete fix, but it gets you to normal working out karaf stuff
16:36:08 <edwarnicke> gershon: Ah
16:36:16 <edwarnicke> So, your problem is really really simple
16:36:40 <edwarnicke> Are all of your versions for your internal artifacts -SNAPSHOT versions
16:36:44 <edwarnicke> Does it build
16:36:55 <ChristineH> edwarnicke: the gerrit 11195 you pushed returns: Build Unstable. The jenkins console shows similar test error: Missing Constraint org.opendaylight.yang.gen.v1.urn.opendaylight.snmp4sdn.md.vlan.rev140815.  Let me check the features.xml...
16:36:59 <edwarnicke> (later we can talk about testing ;) )
16:37:13 <edwarnicke> ChristineH: Yes, because it doesn't completely solve your karaf feature issues
16:37:19 <edwarnicke> It just moves the ball forward
16:38:11 <gzhao> ChristineH: is that the same vlan issue you talked about or different one
16:40:33 <gzhao> ChristineH:  edwarnicke's patch turns on the test and resolve the testcontainer exception, however, it seems the vlan issue still need to be resolved.
16:41:05 <ChristineH> gzhao, edwarnicke: it's different from Luis's now, but looks the same as I encountered when installing snmp4sdn in karaf.
16:41:32 <edwarnicke> ChristineH: OK, so a couple of observations
16:41:47 <ChristineH> gzhao, edwarnicke: the error message in karaf is: Error resolving artifact org.opendaylight.snmp4sdn:0.1.3-SNAPSHOT:vlanmd-model: Could not find artifact org.opendaylight.snmp4sdn:md:0.1....
16:42:00 <edwarnicke> ChristineH: You probably need odl-msdsal-broker and odl-yangtools-models
16:42:17 <edwarnicke> ChristineH: Look at sfc/features/ for an example (including the <repos> you need)
16:42:24 <edwarnicke> gzhao: Could you help her work through that?
16:43:04 <gzhao> edwarnicke: let me try on my local
16:43:32 <gershon> edwarnicke: I think I got it. Will deal with it a bit and will let you know once done. Thanks very much for assistence!
16:43:41 <edwarnicke> gershon: Thank you
16:43:46 <edwarnicke> gershon: A couple of bits of info
16:43:52 <edwarnicke> RC1 is cut at 5pm PST
16:44:03 <edwarnicke> I have a test job I would prefer to run before then to make sure all is well
16:44:09 <edwarnicke> It takes about 3.5-4 hours to run
16:44:33 <edwarnicke> So I would *really* like to have stuff in hand before noon PST if at all possible :)
16:44:38 <edwarnicke> (and ASAP is better :) )
16:50:45 <gershon> edwarnicke: Hm, according to your notes seems that I need to do it now to be ready on time...
16:51:48 <edwarnicke> 10am PST is in 10 minutes... so you have 2 hours 10 minutes
16:52:05 <edwarnicke> gershon: Also note carefully: "I would prefer"
16:52:19 <edwarnicke> gershon: noon PST is not the deadline, 5pm PST is the deadline
16:52:54 <edwarnicke> gershon: But if I have to do the first run without test at 5pm PST, I have to stay up to make sure you guys build fine there, and if something goes wrong we don't have a window to fix it :)
16:52:59 <edwarnicke> gershon: Thus my preference :)
16:54:01 <gershon> The problem is that I have several fixes in the pool for RC2 that I almost finished and think it will be really great for me if you will exceptionally allow me to deliver this small change with my other fixes...
16:54:03 <gzhao> ChristineH: shall we try to add those <repo> and odl-msdsal-broker and odl-yangtools-models ?
16:55:52 <ChristineH> gzhao, edwarnicke: I just clone snmp4sdn and build it in my local, then the error message in Karaf changes:
16:55:57 <gershon> edwarnicke: I believe I could deliver it much before RC2 official date, but not in near 2 hours:)
16:55:57 <ChristineH> Error executing command: Could not start bundle mvn:org.opendaylight.snmp4sdn/vlanmd-model/0.1.3-SNAPSHOT in feature(s) odl-snmp4sdn-snmp4sdn-0.1.3-SNAPSHOT: The bun dle "org.opendaylight.snmp4sdn.vlanmd-model_0.1.3.SNAPSHOT [136]" could not be resolved. Reason: Missing Constraint: Import-Package: com.google.common.collect; versi on="[14.0.0,15.0.0)"
16:56:47 <edwarnicke> ChristineH: Can you push your current files so I can take a look?
16:57:51 <ChristineH> edwarnicke: my current files are sync with gerrit snmp repo now.
16:59:08 <edwarnicke> OK... did you see my comment "ChristineH: You probably need odl-msdsal-broker and odl-yangtools-models"
16:59:13 <edwarnicke> ChristineH: Look at sfc/features/ for an example (including the <repos> you need)
16:59:19 <edwarnicke> And did you add those?
17:00:22 <ChristineH> oh, not yet. The error in karaf I just reported is snmp4sdn without sfc/features
17:00:35 <ChristineH> edwarnicke: ok, let me try this... thanks :)
17:01:20 <edwarnicke> ChristineH: Please note, you don't need the sfc/features... its just an example of how to get the repos for the odl-mdsal-broker and odl-yangtools-models features :)
17:01:26 <edwarnicke> ChristineH: No worries :)
17:01:54 <ChristineH> edwarnicke: understand, thanks :)
17:06:13 <gzhao> edwarnicke: ChristineH I added repo in sfc and odl-msdsal-broker and odl-yangtools-models
17:06:26 <gzhao> followed by following error
17:06:34 <gzhao> https://www.irccloud.com/pastebin/YBIm1UMz
17:06:56 <edwarnicke> gzhao: I see that error a lot, it appears harmless
17:07:09 <edwarnicke> gzhao: Do the tests pass or fail?
17:08:09 <gzhao> https://www.irccloud.com/pastebin/jzv3ZVgP
17:12:45 <gzhao> missing feature-yangtools, let me add to pom.xml and try again
17:16:23 <edwarnicke> gzhao: Progress! :)
17:16:42 <gzhao> edwarnicke: get closer, at least I think
17:16:52 <gzhao> missing mdsal, adding it
17:17:06 <edwarnicke> Cool :)
17:29:20 <ChristineH> edwarnicke: excuse me. The gerrit 11195 (as you afformentioned), should I adopt it to my code?   As for sfc/features/, I add <repos> and the features (odl-mdsal-broker, odl-wangtools-models), also add dependencies to features/pom.xml for the two features. And error in karaf: Exception in org.opendaylight.controller.config.manager.impl.osgi.ConfigManagerActivator.start() of bundle org.opendaylight.controller.config-ma
17:33:56 <edwarnicke> ChristineH: I would suggest that you amend it with changes until it works
17:34:18 <edwarnicke> ChristineH: Could you push an amended patch set so I can see what you have?
17:37:01 <ChristineH> edwarnicke: actually I'm not sure how to use amend. Is it like this: git fetch ... --> git commit --amend --> git push ...  ?
17:37:11 <edwarnicke> ZYes
17:37:12 <edwarnicke> Yes
17:37:16 <edwarnicke> But you will need
17:37:20 <edwarnicke> git fetch ...
17:37:25 <edwarnicke> git add <your changes>
17:37:33 <edwarnicke> git commit --amend --signoff
17:37:35 <edwarnicke> git push
17:38:01 <ChristineH> edwarnicke: thanks! wait a moment...
17:39:44 <gzhao> https://www.irccloud.com/pastebin/3606xZiU
17:42:22 <ChristineH> edwarnicke: pushed
17:42:49 <gzhao> edwarnicke: I ried to push my changes, but got I have unstaged changes when I try to rebase
17:42:59 <gzhao> ChristineH:  link?
17:43:13 <ChristineH> gzhao: https://git.opendaylight.org/gerrit/#/c/11195/
17:47:31 <gzhao> ChristineH: LGTM
17:51:46 <gzhao> edwarnicke:  when you have a chance to review  https://git.opendaylight.org/gerrit/#/c/11195/
17:51:56 <edwarnicke> gzhao: Building already :)
17:52:27 <gzhao> edwarnicke: cool, should ChristineH merge it?
17:52:49 <edwarnicke> ChristineH: https://git.opendaylight.org/gerrit/#/c/11195/2 turns off the tests *again*
17:52:55 <edwarnicke> Is https://git.opendaylight.org/gerrit/#/c/11195/2 based on https://git.opendaylight.org/gerrit/#/c/11195/1 ?
17:53:40 <ChristineH> gzhao, edwarnicke: woops
17:54:22 <ChristineH> gzhao, edwarnicke: let me commit patch 2 again...
17:56:50 <edwarnicke> ChristineH: Are you basing on PatchSet1?  And if so, how did you loose the dependencies that the tests need?
17:58:56 <ChristineH> edwarnicke: oh, due to internal reason, I had another copy of code
17:59:13 <edwarnicke> ChristineH: OK... lets get a clean patch *based* on the patchset1
17:59:14 <ChristineH> now I'll use only the code clone from git repo
17:59:21 <edwarnicke> gershon: How are you doing
17:59:22 <edwarnicke> ?
18:01:13 <gzhao> edwarnicke: a side topic, when you have a chance, could you check if this is still correct https://wiki.opendaylight.org/view/Simultaneous_Release:Helium_Release_Plan#Helium_Project_Dependency_Diagram
18:02:29 <edwarnicke> gzhao: Close but not quite
18:02:33 <edwarnicke> I'd leave out toolkit
18:02:41 <edwarnicke> And ovsdb depends on sfc, not the other way around
18:02:58 <edwarnicke> sfc depends on openflowplugin, ovsdb depends on sfc
18:03:01 <gzhao> edwarnicke: that was a mistake, I mean to take out toolkit, but I did ttp,
18:04:55 <gzhao> edwarnicke: https://docs.google.com/spreadsheets/d/1TRYposNDFPaKcySlvwkOXvfR6Anx2EFujlIjoTthhRY/edit#gid=1227179886 <= SFC put ovsdb as karaf dependencies in M4
18:05:39 <ChristineH> edwarnicke, gzhao: patch 3 I just pushed had been built done, error: The bundle "org.opendaylight.snmp4sdn.plugin-shell_0.1.3.SNAPSHOT [192]" could not be resolved. Reason: Missing Constraint: Import-Package: org.opendaylight.snmp4sdn; version="0.0.0"
18:10:06 <edwarnicke> gershon: Are you still there?
18:11:19 <edwarnicke> gzhao: We thought we were going to be, but grep -r --include=pom.xml ovsdb . in sfc/ shows we are not
18:16:50 <gzhao> edwarnicke: we can discuss this later,ChristineH 's one is more important -:)
18:21:44 <edwarnicke> ChristineH: You still aren't based on PatchSet1... I already fixed that there
18:22:09 <edwarnicke> ChristineH: Please start with PatchSet1 and manually make your changes again and repush
18:22:34 <ChristineH> edwarnicke: oh really, my... sorry for inconvenience
18:22:55 <edwarnicke> ChristineH: no worries :)
18:23:02 <edwarnicke> ChristineH: I'm not annoyed or unhappy :)
18:23:09 <edwarnicke> ChristineH: Just want to get you back on track :)
18:26:20 <gzhao> edwarnicke: for logical dependencies
18:26:40 <gzhao> edwarnicke:  we don't need to show controller ->aaa right?
18:26:51 <edwarnicke> gzhao: Hmm... good question
18:26:57 <edwarnicke> In truth it is a dependency
18:27:07 <edwarnicke> But aaa also depends on controller
18:27:45 <gzhao> that already show
18:35:53 <gzhao> ChristineH: are you doing, I know it is very late for you
18:38:39 <edwarnicke> gershon: There?
18:39:18 <ChristineH> gzhao: well... just fine :) thanks :)  I think having a long sleep and then deep meditation tomorrow will recover. Hope RC1 cut can be just in time :)
18:40:32 <ChristineH> edwarnicke, gzhao: patch 4 pushed and built. New error appears...
18:40:43 <gzhao> ChristineH: great
18:43:12 <gzhao> there seems to have some syntax error, wonder if you can remove all the /r at the end of features/src/main/resources/features.xml
18:45:22 <gzhao> ChristineH: you can use vi  %s#ctrl+V M## to remove all ^M, just use ctrl V to get ^
18:47:54 <edwarnicke> ChristineH: <repository> tags do not go inside features
18:48:02 <edwarnicke> <feature> tags go inside <features>
18:48:08 <edwarnicke> Please have a look at the sfc example
18:57:20 <ChristineH> gzhao: I can't remove the \r with vi ... just keep trying
18:57:48 <gzhao> ChristineH: in vi does it show up like ^M?
18:58:02 <edwarnicke> ChristineH: http://stackoverflow.com/a/651185
18:58:05 <ChristineH> edwarnicke: it seems the code already follow your reminder
18:58:39 <gzhao> edwarnicke: that is even better.
19:00:06 <ChristineH> edwarnicke: oh, I was wrong, "<repository> tags do not go inside features" is not followed.  But in sfc example, <repo> is inside <features>...
19:00:57 <edwarnicke> It is inside <features> it is not inside <feature>
19:03:37 <gzhao> ChristineH: line 23
19:05:59 <ChristineH> edwarnicke: ok. It looks current code already follows '<repo> is inside <features> not inside <feature>'  and '<feature> is indside <features>'
19:06:06 <gzhao> ChristineH: should that be odl-mdsal-broker and odl-yangtools-models?
19:07:56 <ChristineH> gzhao: there two features were suggested by edwarnicke (mentioned on [00:42])
19:10:17 <ChristineH> gzhao, edwarnicke: I just pushed patch 5 that removes \r in features.xml
19:11:50 <gzhao> ChristineH: in line 23, 24 you still have <repository>inside feature
19:12:28 <gzhao> ChristineH: I wonder should it be odl-mdsal-broker and odl-yangtools-models be in these two lines?
19:12:58 <ChristineH> gzhao: oh, I must be not clear now :p
19:13:15 <ChristineH> gzhao: it's indeed typo... let me correct it
19:24:55 <ChristineH> gzhao, edwarnicke: features.xml is corrected in patch 6, the build error: The bundle "org.opendaylight.snmp4sdn.plugin-shell_0.1.3.SNAPSHOT [192]" could not be resolved. Reason: Missing Constraint: Import-Package: org.opendaylight.snmp4sdn; version="0.0.0"
19:26:40 <edwarnicke> ChristineH: You are still not based on patchset1, where that is fixed
19:27:13 <edwarnicke> ChristineH: Wait
19:27:16 <edwarnicke> I may be mistaken
19:27:16 <edwarnicke> Checking
19:43:58 <edwarnicke> Fixed: https://git.opendaylight.org/gerrit/#/c/11195/
19:44:05 <edwarnicke> ChristineH: gzhao Fixed https://git.opendaylight.org/gerrit/#/c/11195/
19:44:12 <edwarnicke> gershon: Where are you?
19:44:58 <gzhao> yangtools-binding
19:46:42 <gzhao> edwarnicke: ChristineH am I too pick? \r is back and could we remove the 4 extra white space on pom.xml
19:48:07 <ChristineH> gzhao: sure, wait a moment
19:49:39 <gzhao> ChristineH: thanks, I missed yangtools-binding
19:50:07 <gzhao> ChristineH: glad to see you are still awake
19:50:39 <edwarnicke> gzhao: Apologies about the \r... I may not have been current
19:50:45 <edwarnicke> gzhao: Should be easy for you guys to fix
19:51:16 <gzhao> edwarnicke: that is something we can live with. -:) you resolve the bigger issue
19:51:33 <edwarnicke> Please do so and get it merged, then push a patch to integration referencing the merge job tests *directly* by link and ping LuisGomez about it
19:51:43 <gzhao> glad finally everything looks good.
19:51:45 <ChristineH> gzhao: features.xml in patch 7 contains \r, I just pushed patch 8
19:51:55 <edwarnicke> gzhao: Now if we could only get defense4all to respond :(
19:51:56 <gzhao> will D4A make the change for RC1?
19:52:06 <edwarnicke> gzhao: I don't know, gershon wandered away
19:52:11 <edwarnicke> gzhao: He still has time
19:52:26 <edwarnicke> gzhao: But I wish he wouldn't cut it so close
19:52:33 <edwarnicke> gzhao: The fix should have taken about 20 minutes :(
19:52:40 <gzhao> edwarnicke:  that is not good, because it is 11:00pm for them
19:52:52 <edwarnicke> Yes
19:53:25 <gzhao> will it be ok if they are not in RC1 and test by themselves with RC1 code
19:53:54 <gzhao> because, we can not wait for them for RC1
19:55:50 <gzhao> gershon: Hello, are you still there?
19:57:43 <gzhao> for snmp4sdn, do they need to merge anything to integration? or this is it, the test issue should be fixed.
19:58:11 <edwarnicke> gzhao: Yes, snmp4sdn needs to push a patch to integration to turn themselves back on
19:58:34 <gzhao> ChristineH well, hope this is the last push
19:58:43 <gzhao> ChristineH: thanks a lot of staying so late
19:58:46 <edwarnicke> gzhao: I would recommend including a link to https://jenkins.opendaylight.org/snmp4sdn/job/snmp4sdn-merge/org.opendaylight.snmp4sdn$features-snmp4sdn/137/testReport/ showing you both pass now and have ongoing testing
19:59:03 <edwarnicke> gzhao: Do you guys need anything else from me... I am thinking I should get lunch
19:59:15 <ChristineH> gzhao: thank you and edwarnicke also!
19:59:19 <gzhao> edwarnicke: go for it
19:59:35 <gzhao> edwarnicke: I will go once this is in integration
20:00:48 <gzhao> ChristineH: are you doing the patch for integration?
20:02:17 <ChristineH> gzhao: I'm checking integration's features/pom.xml features.xml to add snmp4sdn. Seems only need to remove the <!-- on snmp4sdn in features.xml
20:03:15 <gzhao> ChristineH: cool
20:05:11 <gzhao> ChristineH: we will make sure one of integration committeers will be online to merge the change
20:06:43 <lori> hi everyone
20:06:49 <gzhao> Hi Lori
20:06:54 <lori> is there a 'config.ini' equivalent in Karaf?
20:07:10 <lori> we had some functionality using settings in that file
20:07:21 <lori> was it migrated to some other file?
20:07:29 <lori> or was it dropped?
20:07:41 <lori> and people should not use it?
20:08:28 <gzhao> need to ping Madhu or mlemey for that
20:09:20 <gzhao> lori: ed just out for lunch, otherwise, he might be able to answer your question
20:09:59 <ChristineH> gzhao: just pushed to integration:  https://git.opendaylight.org/gerrit/#/c/11207/
20:10:58 <gzhao> CASP3R: hello
20:10:58 <lori> thanks gzhao
20:11:04 <edwarnicke> lori: Yes
20:11:05 <CASP3R> hey
20:11:08 <gzhao> lori: you are welcome
20:11:12 <edwarnicke> lori: Two options
20:11:39 <gzhao> CASP3R: could you merge  https://git.opendaylight.org/gerrit/#/c/11207/
20:11:39 <edwarnicke> 1) controller/opendaylight/distributions/opendaylight-karaf-resources/src/main/resources/etc/custom.properties
20:11:43 <edwarnicke> 2)  Use ConfigAdmin
20:12:01 <edwarnicke> While I would vastly prefer #2... I strongly suspect #1 is the right answer for you at this moment ;)
20:12:04 <CASP3R> gzhao lets see what jenkins says
20:12:32 <gzhao> edwarnicke: that is a quick lunch-:)
20:12:33 <lori> edwarnicke: probably, I don't know ConfigAdmin, and I assume it would require new code
20:12:36 <gzhao> CASP3R: sure
20:12:39 <gzhao> CASP3R: thanks
20:12:48 <lori> edwarnicke: while 1) is just a bugfix
20:13:00 <edwarnicke> Yep :)
20:13:06 <CASP3R> i cant cancel the job before it as it's a merge job so it be around a 40-60 minute wait for the result
20:13:15 <ChristineH> gzaho: but jenkins looks pending... https://jenkins.opendaylight.org/integration/job/integration-master-verify-distributions/  job #348. So I'll be offline now. I think I'll take a look at my mailbox after 8 hours.
20:13:16 <ChristineH> Bye, all.
20:13:34 <lori> shouldn't have projects having config options in config.ini been notified by this change? :(
20:13:44 <gzhao> CASP3R: thanks
20:14:20 <gzhao> ChristineH: CASP3R clear the jobs in front of it. Have a good sleep it is almost morning there.
20:14:50 <gzhao> edwarnicke: that is a quick lunch -:)
20:15:29 <gzhao> I will go get something to eat, since it will take 40-60 minutes to verify. and gershon is not here , I am ending the meeting.
20:15:34 <gzhao> #endmeeting